From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D8B2C7EE2F for ; Wed, 31 May 2023 13:06:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233148AbjEaNGG (ORCPT ); Wed, 31 May 2023 09:06:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236479AbjEaNFX (ORCPT ); Wed, 31 May 2023 09:05:23 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B768D19D for ; Wed, 31 May 2023 06:04:51 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 2EB2C68BFE; Wed, 31 May 2023 15:03:26 +0200 (CEST) Date: Wed, 31 May 2023 15:03:25 +0200 From: Christoph Hellwig To: Daniel Gomez Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Pankaj Raghav , "mcgrof@kernel.org" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] nvme: Increase block size variable size to 32-bit Message-ID: <20230531130325.GE27468@lst.de> References: <20230530154231.8313-1-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530154231.8313-1-da.gomez@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + u32 bs = 1 << ns->lba_shift; Make that 1 a 1U so that we're not going to run into sign extension issues when using up all bits in the u32 :) Otherwise looks good: Reviewed-by: Christoph Hellwig