From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Osama Muhammad <osmtendev@gmail.com>,
Sasha Levin <sashal@kernel.org>,
lgirdwood@gmail.com, broonie@kernel.org
Subject: [PATCH AUTOSEL 5.10 08/21] regulator: Fix error checking for debugfs_create_dir
Date: Wed, 31 May 2023 09:44:01 -0400 [thread overview]
Message-ID: <20230531134415.3384458-8-sashal@kernel.org> (raw)
In-Reply-To: <20230531134415.3384458-1-sashal@kernel.org>
From: Osama Muhammad <osmtendev@gmail.com>
[ Upstream commit 2bf1c45be3b8f3a3f898d0756c1282f09719debd ]
This patch fixes the error checking in core.c in debugfs_create_dir.
The correct way to check if an error occurred is 'IS_ERR' inline function.
Signed-off-by: Osama Muhammad <osmtendev@gmail.com
Suggested-by: Ivan Orlov <ivan.orlov0322@gmail.com
Link: https://lore.kernel.org/r/20230515172938.13338-1-osmtendev@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/regulator/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 47a04c5f7a9b8..f5ab74683b58a 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -5032,7 +5032,7 @@ static void rdev_init_debugfs(struct regulator_dev *rdev)
}
rdev->debugfs = debugfs_create_dir(rname, debugfs_root);
- if (!rdev->debugfs) {
+ if (IS_ERR(rdev->debugfs)) {
rdev_warn(rdev, "Failed to create debugfs directory\n");
return;
}
@@ -5937,7 +5937,7 @@ static int __init regulator_init(void)
ret = class_register(®ulator_class);
debugfs_root = debugfs_create_dir("regulator", NULL);
- if (!debugfs_root)
+ if (IS_ERR(debugfs_root))
pr_warn("regulator: Failed to create debugfs directory\n");
#ifdef CONFIG_DEBUG_FS
--
2.39.2
next prev parent reply other threads:[~2023-05-31 13:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 13:43 [PATCH AUTOSEL 5.10 01/21] power: supply: ab8500: Fix external_power_changed race Sasha Levin
2023-05-31 13:43 ` [PATCH AUTOSEL 5.10 02/21] power: supply: sc27xx: " Sasha Levin
2023-05-31 13:43 ` [PATCH AUTOSEL 5.10 03/21] power: supply: bq27xxx: Use mod_delayed_work() instead of cancel() + schedule() Sasha Levin
2023-05-31 13:43 ` [PATCH AUTOSEL 5.10 04/21] ARM: dts: vexpress: add missing cache properties Sasha Levin
2023-05-31 13:43 ` [PATCH AUTOSEL 5.10 05/21] tools: gpio: fix debounce_period_us output of lsgpio Sasha Levin
2023-05-31 13:43 ` [PATCH AUTOSEL 5.10 06/21] power: supply: Ratelimit no data debug output Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 07/21] platform/x86: asus-wmi: Ignore WMI events with codes 0x7B, 0xC0 Sasha Levin
2023-05-31 13:44 ` Sasha Levin [this message]
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 09/21] irqchip/gic-v3: Disable pseudo NMIs on Mediatek devices w/ firmware issues Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 10/21] power: supply: Fix logic checking if system is running from battery Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 11/21] btrfs: scrub: try harder to mark RAID56 block groups read-only Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 12/21] btrfs: handle memory allocation failure in btrfs_csum_one_bio Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 13/21] ASoC: soc-pcm: test if a BE can be prepared Sasha Levin
2023-06-16 19:30 ` Pavel Machek
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 14/21] parisc: Improve cache flushing for PCXL in arch_sync_dma_for_cpu() Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 15/21] parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory() Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 16/21] MIPS: Restore Au1300 support Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 17/21] MIPS: Alchemy: fix dbdma2 Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 18/21] mips: Move initrd_start check after initrd address sanitisation Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 19/21] ASoC: dwc: move DMA init to snd_soc_dai_driver probe() Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 20/21] xen/blkfront: Only check REQ_FUA for writes Sasha Levin
2023-05-31 13:44 ` [PATCH AUTOSEL 5.10 21/21] drm:amd:amdgpu: Fix missing buffer object unlock in failure path Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531134415.3384458-8-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osmtendev@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox