From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5E8C7EE2E for ; Wed, 31 May 2023 13:49:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236793AbjEaNtW (ORCPT ); Wed, 31 May 2023 09:49:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236995AbjEaNsn (ORCPT ); Wed, 31 May 2023 09:48:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E72E2702; Wed, 31 May 2023 06:44:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4C3C63B81; Wed, 31 May 2023 13:44:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DD52C433EF; Wed, 31 May 2023 13:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685540667; bh=GYoAnakjNSnWlY/DDKr/dZmA1UPFB3iX//mzuixW2Z8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UiR9j360k1nIJydl+jdzrBnVIDZayRthWYOQuMIyUxuWtFcP7WyKI+1Vx2tLCGetb aQ7vmdC3Wt+6LZCM8t64VZymiFZ1qvCUOsm4TXG+4FNeHhO8aeRinaU/itM5UV6JJ2 NZ7a2DEIvmhzPheXg+h8j2O2VJzikNFyc/mfpx1YAb7qOOga3GtAzJ2/ppW7uekF1Z uOnAIKrHM7tv49BS+eXNRylAa4FJA5misA51IatcWy7g+PKqLhG/lF+AbgBDLrrpUH PkSCs6e8IFNpBcoznKrkXhAPjyQmPOM7RPqSQ2Woui800URnOfTcv66ju/ysLb/p+2 UKqfwdfXSg2Ng== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Osama Muhammad , Sasha Levin , lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH AUTOSEL 5.10 08/21] regulator: Fix error checking for debugfs_create_dir Date: Wed, 31 May 2023 09:44:01 -0400 Message-Id: <20230531134415.3384458-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230531134415.3384458-1-sashal@kernel.org> References: <20230531134415.3384458-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Osama Muhammad [ Upstream commit 2bf1c45be3b8f3a3f898d0756c1282f09719debd ] This patch fixes the error checking in core.c in debugfs_create_dir. The correct way to check if an error occurred is 'IS_ERR' inline function. Signed-off-by: Osama Muhammad --- drivers/regulator/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 47a04c5f7a9b8..f5ab74683b58a 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -5032,7 +5032,7 @@ static void rdev_init_debugfs(struct regulator_dev *rdev) } rdev->debugfs = debugfs_create_dir(rname, debugfs_root); - if (!rdev->debugfs) { + if (IS_ERR(rdev->debugfs)) { rdev_warn(rdev, "Failed to create debugfs directory\n"); return; } @@ -5937,7 +5937,7 @@ static int __init regulator_init(void) ret = class_register(®ulator_class); debugfs_root = debugfs_create_dir("regulator", NULL); - if (!debugfs_root) + if (IS_ERR(debugfs_root)) pr_warn("regulator: Failed to create debugfs directory\n"); #ifdef CONFIG_DEBUG_FS -- 2.39.2