From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC47C7EE23 for ; Wed, 31 May 2023 13:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237127AbjEaNxK (ORCPT ); Wed, 31 May 2023 09:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237341AbjEaNu0 (ORCPT ); Wed, 31 May 2023 09:50:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BFB41BFA; Wed, 31 May 2023 06:45:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A9C8F63BA9; Wed, 31 May 2023 13:45:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C6CBC4339B; Wed, 31 May 2023 13:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685540749; bh=pXuGXvLx6xbjWM3oEF84YMrCgQeTs9pbJ5iGIc8NyfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HOqzCavL3FLKSw4jZg/W3+HTkFl4VHnXzbQYFSKMzagjdgfyVcx/k8sr6DuU7jHdR zWQ9I45BogemNMQNEIK8bSpXj7hvVep5G9SxQN9Glfl4N5W+8Cnm0NikeIFR+4rhBr 3iL8nwi3pJbZdmDMlZUSAir7rkyi6dE87dBgtSv1K6RR4AwFueINfEtRPeaCb7CNwH nJL4hl/TOu66xF0E3FmhN/yqC+izuDz4n4zvXdXJoMTbwMchCEsxfcXC9xQr7lZ/TX cOd/9ezrTkBbOE1SbolRAJ+Qx20guePiRhOHTAPWtIwM7mxlb3ROIQ+wFkEdmDSphd oSzXIaMUN/Slw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Osama Muhammad , Sasha Levin , lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH AUTOSEL 4.19 05/13] regulator: Fix error checking for debugfs_create_dir Date: Wed, 31 May 2023 09:45:33 -0400 Message-Id: <20230531134541.3385043-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230531134541.3385043-1-sashal@kernel.org> References: <20230531134541.3385043-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Osama Muhammad [ Upstream commit 2bf1c45be3b8f3a3f898d0756c1282f09719debd ] This patch fixes the error checking in core.c in debugfs_create_dir. The correct way to check if an error occurred is 'IS_ERR' inline function. Signed-off-by: Osama Muhammad --- drivers/regulator/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 11656b3836748..14f9977f1ec08 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4181,7 +4181,7 @@ static void rdev_init_debugfs(struct regulator_dev *rdev) } rdev->debugfs = debugfs_create_dir(rname, debugfs_root); - if (!rdev->debugfs) { + if (IS_ERR(rdev->debugfs)) { rdev_warn(rdev, "Failed to create debugfs directory\n"); return; } @@ -4843,7 +4843,7 @@ static int __init regulator_init(void) ret = class_register(®ulator_class); debugfs_root = debugfs_create_dir("regulator", NULL); - if (!debugfs_root) + if (IS_ERR(debugfs_root)) pr_warn("regulator: Failed to create debugfs directory\n"); debugfs_create_file("supply_map", 0444, debugfs_root, NULL, -- 2.39.2