From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60847C77B7A for ; Wed, 31 May 2023 13:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237358AbjEaNx0 (ORCPT ); Wed, 31 May 2023 09:53:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237360AbjEaNu2 (ORCPT ); Wed, 31 May 2023 09:50:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F75B30E0; Wed, 31 May 2023 06:46:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 603BC63B60; Wed, 31 May 2023 13:45:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9A7AC4339B; Wed, 31 May 2023 13:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685540755; bh=RXkrOW2+K+RN5YvBGNUiLyWD8tX2m2QKFu2Inzk638A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RRSXaWU1MxNAbAveWCveSfLQRqk6udCs3iKQfyM0leYZrB5OQQ4XZ8ln6bm4XBOHn 4Akk62m1mG6uKpYpumYcrHhbpvVHeEOWJkGxuQ5JewYTdcOjzvVSW6kynaFBR4ZXvL 7BhudxKvDTKl7tWi17XNeG2fVBUedt8tSiiuSVWaiBWpAeAbvKOY6tColVjxgbdwfU klSFd7wwIGvF2eY4nqs12Kq7ToYaE2oux1cxYsYrGEwMrRbuctqf4FvnZ5sjAyzMa0 d7DWTtpkYuPvvzaSrQ445/NHIDhIPHT/x8waGe/R8Vmz/+pW6NEiAEOsY5hdkSk+61 I2QOqmvBOaNMQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Helge Deller , Sasha Levin , James.Bottomley@HansenPartnership.com, airlied@redhat.com, linux-parisc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.19 09/13] parisc: Flush gatt writes and adjust gatt mask in parisc_agp_mask_memory() Date: Wed, 31 May 2023 09:45:37 -0400 Message-Id: <20230531134541.3385043-9-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230531134541.3385043-1-sashal@kernel.org> References: <20230531134541.3385043-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Helge Deller [ Upstream commit d703797380c540bbeac03f104ebcfc364eaf47cc ] Flush caches after changing gatt entries and calculate entry according to SBA requirements. Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/char/agp/parisc-agp.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/char/agp/parisc-agp.c b/drivers/char/agp/parisc-agp.c index 1d5510cb6db4e..f6d5a9b52cfe9 100644 --- a/drivers/char/agp/parisc-agp.c +++ b/drivers/char/agp/parisc-agp.c @@ -94,6 +94,9 @@ parisc_agp_tlbflush(struct agp_memory *mem) { struct _parisc_agp_info *info = &parisc_agp_info; + /* force fdc ops to be visible to IOMMU */ + asm_io_sync(); + writeq(info->gart_base | ilog2(info->gart_size), info->ioc_regs+IOC_PCOM); readq(info->ioc_regs+IOC_PCOM); /* flush */ } @@ -162,6 +165,7 @@ parisc_agp_insert_memory(struct agp_memory *mem, off_t pg_start, int type) info->gatt[j] = parisc_agp_mask_memory(agp_bridge, paddr, type); + asm_io_fdc(&info->gatt[j]); } } @@ -195,7 +199,16 @@ static unsigned long parisc_agp_mask_memory(struct agp_bridge_data *bridge, dma_addr_t addr, int type) { - return SBA_PDIR_VALID_BIT | addr; + unsigned ci; /* coherent index */ + dma_addr_t pa; + + pa = addr & IOVP_MASK; + asm("lci 0(%1), %0" : "=r" (ci) : "r" (phys_to_virt(pa))); + + pa |= (ci >> PAGE_SHIFT) & 0xff;/* move CI (8 bits) into lowest byte */ + pa |= SBA_PDIR_VALID_BIT; /* set "valid" bit */ + + return cpu_to_le64(pa); } static void -- 2.39.2