From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C98C7EE23 for ; Thu, 1 Jun 2023 05:21:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbjFAFVs (ORCPT ); Thu, 1 Jun 2023 01:21:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbjFAFVq (ORCPT ); Thu, 1 Jun 2023 01:21:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D974312C for ; Wed, 31 May 2023 22:21:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51C4D614CE for ; Thu, 1 Jun 2023 05:21:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B3D5C433EF; Thu, 1 Jun 2023 05:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685596903; bh=Koxe39K4Rpi6vC8WW4spnDTwr5GtFMwjDnN5f/mDfKo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Znlc28ycUx7Q2gzFML6vW1pP7LS1yC266N7++xoSeif/pDycBYwl9E3HHAfo7fGCw 17m6m6B6WCSyqQWPyekZiVyrgwDd/G3iFN6lvn/uureuSSmLGcpq93ULQ+c0SN9su0 xbW9+KYYmizVg+Czp19NyaA3nnDMvwfAP8M6pvTsOl2cNI/JX8BUUhJjVtoSg6kOip SiISVDMIm7mpJ54S2NiagwtrPsTKJEAshsPbxNzdO88VdcPvCX9UNsqaoDhEVWbsDj gPuR16qOhCVlX0dNPzUbnfbdIoohVnFH1FJgCCH5tGkX0ftis4oYf1UZCvtRScOqcC JmenaeXsKyNDQ== Date: Thu, 1 Jun 2023 08:21:16 +0300 From: Mike Rapoport To: Yuwei Guan Cc: akpm@linux-foundation.org, wangkefeng.wang@huawei.com, anshuman.khandual@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: Update nid info in memblock debugfs Message-ID: <20230601052116.GC395338@kernel.org> References: <20230529062002.157-1-ssawgyw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230529062002.157-1-ssawgyw@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 29, 2023 at 02:20:02PM +0800, Yuwei Guan wrote: > The node id for memblock reserved regions will be wrong, > so let's show 'x' for reg->nid == MAX_NUMNODES in debugfs to keep it align. > > Suggested-by: Mike Rapoport (IBM) > Signed-off-by: Kefeng Wang > Signed-off-by: Yuwei Guan I believe this could use Co-developed-by tags. Please take a look at Documentation/process/submitting-patches.rst > --- > mm/memblock.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index c5c80d9bcea3..3d449aaba052 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2169,17 +2169,21 @@ static int memblock_debug_show(struct seq_file *m, void *private) > { > struct memblock_type *type = m->private; > struct memblock_region *reg; > - int i, j; > + int i, j, nid; > unsigned int count = ARRAY_SIZE(flagname); > phys_addr_t end; > > for (i = 0; i < type->cnt; i++) { > reg = &type->regions[i]; > end = reg->base + reg->size - 1; > + nid = memblock_get_region_node(reg); > > seq_printf(m, "%4d: ", i); > seq_printf(m, "%pa..%pa ", ®->base, &end); > - seq_printf(m, "%4d ", memblock_get_region_node(reg)); > + if (nid != MAX_NUMNODES) > + seq_printf(m, "%4d ", nid); > + else > + seq_printf(m, "%4c ", 'x'); > if (reg->flags) { > for (j = 0; j < count; j++) { > if (reg->flags & (1U << j)) { > -- > 2.34.1 > -- Sincerely yours, Mike.