Re: [PATCH] mm: remove unused alloc_pages_bulk_list()

Mel Gorman
2022-12-19T10:07:46Z

On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote:
> + Mel
>
> On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote:
> > I think we're waiting to see if any users show up. It's only been 18
> > months or so, so perhaps wait a little longer?
>
> Apologies, I should have researched the background of this further. I see it was
> added speculatively in 0f87d9d30f.
>
> > Also, if we do get rid of this, then __alloc_pages_bulk() can lose
> > the "list" argument.
>
> Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage,
> otherwise we can drop the idea and wait for users to emerge.

I reckon we should give it another few months until May. There has been
one user recently that tried to use list but it turned out arrays were
more appropriate.

--
Mel Gorman
SUSE Labs