From: Mike Rapoport <rppt@kernel.org>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/mm_init.c: move set_pageblock_order() to free_area_init()
Date: Thu, 1 Jun 2023 13:34:50 +0300 [thread overview]
Message-ID: <20230601103450.GD395338@kernel.org> (raw)
In-Reply-To: <20230601063536.26882-1-haifeng.xu@shopee.com>
On Thu, Jun 01, 2023 at 06:35:35AM +0000, Haifeng Xu wrote:
> pageblock_order only needs to be set once, there is no need to
> initialize it in every zone/node.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> mm/mm_init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 93821824271a..232efac9a929 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1583,7 +1583,6 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
> if (!size)
> continue;
>
> - set_pageblock_order();
> setup_usemap(zone);
> init_currently_empty_zone(zone, zone->zone_start_pfn, size);
> }
> @@ -1850,6 +1849,8 @@ void __init free_area_init(unsigned long *max_zone_pfn)
> /* Initialise every node */
> mminit_verify_pageflags_layout();
> setup_nr_node_ids();
> + set_pageblock_order();
> +
> for_each_node(nid) {
> pg_data_t *pgdat;
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2023-06-01 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 6:35 [PATCH 1/2] mm/mm_init.c: move set_pageblock_order() to free_area_init() Haifeng Xu
2023-06-01 10:34 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601103450.GD395338@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=haifeng.xu@shopee.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox