* [PATCH 1/2] mm/mm_init.c: move set_pageblock_order() to free_area_init()
@ 2023-06-01 6:35 Haifeng Xu
2023-06-01 10:34 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Haifeng Xu @ 2023-06-01 6:35 UTC (permalink / raw)
To: rppt; +Cc: mhocko, akpm, linux-mm, linux-kernel, Haifeng Xu
pageblock_order only needs to be set once, there is no need to
initialize it in every zone/node.
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
mm/mm_init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/mm_init.c b/mm/mm_init.c
index 93821824271a..232efac9a929 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1583,7 +1583,6 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
if (!size)
continue;
- set_pageblock_order();
setup_usemap(zone);
init_currently_empty_zone(zone, zone->zone_start_pfn, size);
}
@@ -1850,6 +1849,8 @@ void __init free_area_init(unsigned long *max_zone_pfn)
/* Initialise every node */
mminit_verify_pageflags_layout();
setup_nr_node_ids();
+ set_pageblock_order();
+
for_each_node(nid) {
pg_data_t *pgdat;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/2] mm/mm_init.c: move set_pageblock_order() to free_area_init()
2023-06-01 6:35 [PATCH 1/2] mm/mm_init.c: move set_pageblock_order() to free_area_init() Haifeng Xu
@ 2023-06-01 10:34 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2023-06-01 10:34 UTC (permalink / raw)
To: Haifeng Xu; +Cc: mhocko, akpm, linux-mm, linux-kernel
On Thu, Jun 01, 2023 at 06:35:35AM +0000, Haifeng Xu wrote:
> pageblock_order only needs to be set once, there is no need to
> initialize it in every zone/node.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> mm/mm_init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 93821824271a..232efac9a929 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1583,7 +1583,6 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
> if (!size)
> continue;
>
> - set_pageblock_order();
> setup_usemap(zone);
> init_currently_empty_zone(zone, zone->zone_start_pfn, size);
> }
> @@ -1850,6 +1849,8 @@ void __init free_area_init(unsigned long *max_zone_pfn)
> /* Initialise every node */
> mminit_verify_pageflags_layout();
> setup_nr_node_ids();
> + set_pageblock_order();
> +
> for_each_node(nid) {
> pg_data_t *pgdat;
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-01 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 6:35 [PATCH 1/2] mm/mm_init.c: move set_pageblock_order() to free_area_init() Haifeng Xu
2023-06-01 10:34 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox