From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D04C77B7A for ; Thu, 1 Jun 2023 14:12:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233876AbjFAOMl (ORCPT ); Thu, 1 Jun 2023 10:12:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233839AbjFAOMg (ORCPT ); Thu, 1 Jun 2023 10:12:36 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED15B129; Thu, 1 Jun 2023 07:12:34 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QX7M31N99z6D91s; Thu, 1 Jun 2023 22:10:23 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 15:12:32 +0100 Date: Thu, 1 Jun 2023 15:12:31 +0100 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , Subject: Re: [PATCH v4 20/23] cxl/pci: Prepare for logging RCH downstream port protocol errors Message-ID: <20230601151231.00003f9f@Huawei.com> In-Reply-To: <11c99f76-2473-bf71-c2d5-f697b1b0e412@amd.com> References: <20230523232214.55282-1-terry.bowman@amd.com> <20230523232214.55282-21-terry.bowman@amd.com> <20230601144942.000075f5@Huawei.com> <11c99f76-2473-bf71-c2d5-f697b1b0e412@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Jun 2023 09:06:23 -0500 Terry Bowman wrote: > Hi Jonathan, thanks for reviewing. > > On 6/1/23 08:49, Jonathan Cameron wrote: > > On Tue, 23 May 2023 18:22:11 -0500 > > Terry Bowman wrote: > > > > The title is very vague. Can it be more specific to what > > is in this patch? The description makes it seem like a bunch of > > unconnected things, but in reality they all chain together > > to get the registers and disable the interrupt. > > > > How about I split this into 2 patches (along lines of register mapping > and root port interrupt disable) and title as: > cxl/pci: Map RCH downstream registers for AER protocol error logging > cxl/pci: Disable root port interrupts in RCH mode Sounds good to me. Jonathan