RE: [PATCH 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP enlightened guest

Michael Kelley (LINUX)
2023-06-08T14:10:09Z

From: Tianyu Lan <ltykernel@gmail.com> Sent: Thursday, June 1, 2023 8:16 AM
>

[snip]

>
> +static __init void hv_snp_get_smp_config(unsigned int early)
> +{
> + /*
> + * The "early" is only to be true when there is AMD
> + * numa support. Hyper-V AMD SEV-SNP guest may not
> + * have numa support. To make sure smp config is
> + * always initialized, do that when early is false.
> + */

I didn't really understand this comment. After doing a little research, let
me suggest this wording:

/*
* The "early" parameter can be true only if old-style AMD
* Opteron NUMA detection is enabled, which should never be
* the case for an SEV-SNP guest. See CONFIG_AMD_NUMA.
* For safety, just do nothing if "early" is true.
*/

Let me know if this new wording makes sense based on your understanding.

Michael

> + if (early)
> + return;
> +