public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>,
	linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
	Tejun Heo <tj@kernel.org>,
	x86@kernel.org
Subject: Re: [tip: sched/core] sched/fair: Multi-LLC select_idle_sibling()
Date: Fri, 2 Jun 2023 13:23:47 +0200	[thread overview]
Message-ID: <20230602112347.GF620383@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <ZHmxHWbkQWvcq+bZ@BLR-5CG11610CF.amd.com>

On Fri, Jun 02, 2023 at 02:36:37PM +0530, Gautham R. Shenoy wrote:

> Yes, this is what the topology looks like
> 
> |---------------------------------------------------------------------------------| 
> |                                                                                 |
> |   ----------- ----------- -----------     ----------- ----------- -----------   |
> |   |(0-7)    | |(8-15)   | |(16-23)  |     |(48-55)  | |(56-63)  | |(64-71)  |   |
> |   | LLC0    | | LLC1    | | LLC2    |     | LLC6    | | LLC7    | | LLC8    |   |
> |   |(96-103) | |(104-111)| |(112-119)|     |(144-151)| |(152-159)| |(160-167)|   |
> |   ----------- ----------- -----------     ----------- ----------- -----------   |
> |                                                                                 |
> |                                                                                 |
> |   ----------- ----------- -----------     ----------- ----------- -----------   |
> |   |(24-31)  | |(32-39)  | |(40-47)  |     |(72-79)  | |(80-87)  | |(88-95)  |   |
> |   | LLC3    | | LLC4    | | LLC5    |     | LLC9    | | LLC10   | | LLC11   |   |
> |   |(120-127)| |(128-135)| |(136-143)|     |(168-175)| |(176-183)| |(184-191)|   |
> |   ----------- ----------- -----------     ----------- ----------- -----------   |
> |                                                                                 |
> |---------------------------------------------------------------------------------|

Yup, that's the pictures I found online.

> > I would think it is the latter since NPS4 does that but let me go verify.
> 
> 2 groups of 6 each is the vertical split which is NPS2.
> 
> 4 groups of 3 each is the vertical and horizontal split, which is
> NPS4.
> 
> In both these cases, currently the domain hierarchy
> 
> SMT --> MC --> NODE --> NUMA
> 
> where the NODE will be the parent of MC and be the 2nd level wakeup domain.
> 
> If we define CLS to be the group with 3 LLCs, which becomes the parent
> of the MC domain, then, the hierarchy would be
> 
> NPS1 : SMT --> MC --> CLS --> DIE
> NPS2 : SMT --> MC --> CLS --> NODE --> NUMA
> NPS4 : SMT --> MC --> CLS --> NUMA
> 
> NPS2 will have 5 domains within a single socket. Oh well!

I think cluster/CLS is taken for L2, we should not re-purpose that for
groups of L3.

Anyway, yes, 5 levels. Shouldn't be a problem though, right?

  reply	other threads:[~2023-06-02 11:23 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230605152531eucas1p2a10401ec2180696cc9a5f2e94a67adca@eucas1p2.samsung.com>
2023-05-31 12:04 ` [tip: sched/core] sched/fair: Multi-LLC select_idle_sibling() tip-bot2 for Peter Zijlstra
2023-06-01  3:41   ` Abel Wu
2023-06-01  8:09     ` Peter Zijlstra
2023-06-01  9:33   ` K Prateek Nayak
2023-06-01 11:13     ` Peter Zijlstra
2023-06-01 11:56       ` Peter Zijlstra
2023-06-01 12:00         ` Peter Zijlstra
2023-06-01 14:47           ` Peter Zijlstra
2023-06-01 15:35             ` Peter Zijlstra
2023-06-02  5:13             ` K Prateek Nayak
2023-06-02  6:54               ` Peter Zijlstra
2023-06-02  9:19                 ` K Prateek Nayak
2023-06-07 18:32                 ` K Prateek Nayak
2023-06-13  8:25                   ` Peter Zijlstra
2023-06-13 10:30                     ` K Prateek Nayak
2023-06-14  8:17                       ` Peter Zijlstra
2023-06-14 14:58                         ` Chen Yu
2023-06-14 15:13                           ` Peter Zijlstra
2023-06-21  7:16                             ` Chen Yu
2023-06-16  6:34                     ` K Prateek Nayak
2023-07-05 11:57                       ` Peter Zijlstra
2023-07-08 13:17                         ` Chen Yu
2023-07-12 17:19                           ` Chen Yu
2023-07-13  3:43                             ` K Prateek Nayak
2023-07-17  1:09                               ` Chen Yu
2023-06-02  7:00               ` Peter Zijlstra
2023-06-01 14:51           ` Peter Zijlstra
2023-06-02  5:17             ` K Prateek Nayak
2023-06-02  9:06               ` Gautham R. Shenoy
2023-06-02 11:23                 ` Peter Zijlstra [this message]
2023-06-01 16:44       ` Chen Yu
2023-06-02  3:12       ` K Prateek Nayak
2023-06-05 15:25   ` Marek Szyprowski
2023-06-05 17:56     ` Peter Zijlstra
2023-06-05 19:07     ` Peter Zijlstra
2023-06-05 22:20       ` Marek Szyprowski
2023-06-06  7:58       ` Chen Yu
2023-06-01  8:43 tip-bot2 for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230602112347.GF620383@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=gautham.shenoy@amd.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox