public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Avichal Rakesh <arakesh@google.com>
Cc: dan.scally@ideasonboard.com, laurent.pinchart@ideasonboard.com,
	thinh.nguyen@synopsys.com, etalvala@google.com,
	jchowdhary@google.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] usb: gadget: uvc: clean up comments and styling in video_pump
Date: Sun, 4 Jun 2023 09:43:40 +0200	[thread overview]
Message-ID: <2023060434-reveler-twice-d92e@gregkh> (raw)
In-Reply-To: <20230602220455.313801-1-arakesh@google.com>

On Fri, Jun 02, 2023 at 03:04:55PM -0700, Avichal Rakesh wrote:
> This patch elaborates on some of the edge cases handled by
> video_pump around setting no_interrupt flag, and brings the
> code style in line with rest of the file.

When you say "and" that usually means it should be a separate patch.

But I really don't see what coding style changes you made here, what was
it?

I can't see any logical changes made here, am I missing them?  Or is
this all just a style-cleanup patch?

thanks,

greg k-h

  reply	other threads:[~2023-06-04  7:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 23:11 [PATCH] usb: gadget: uvc: queue empty isoc requests if no video buffer is available Avichal Rakesh
2023-06-02 15:19 ` Laurent Pinchart
2023-06-02 20:37   ` [PATCH v2] " Avichal Rakesh
2023-06-02 21:16     ` Thinh Nguyen
2023-06-02 22:00       ` Avichal Rakesh
2023-06-02 22:04       ` [PATCH v3] usb: gadget: uvc: clean up comments and styling in video_pump Avichal Rakesh
2023-06-04  7:43         ` Greg KH [this message]
2023-06-04  7:55           ` Laurent Pinchart
2023-06-07 20:28             ` Avichal Rakesh
2023-06-04  7:54         ` Laurent Pinchart
2023-06-02 20:39   ` [PATCH] usb: gadget: uvc: queue empty isoc requests if no video buffer is available Avichal Rakesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023060434-reveler-twice-d92e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arakesh@google.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=etalvala@google.com \
    --cc=jchowdhary@google.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=thinh.nguyen@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox