From: Raag Jadav <raagjadav@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Raag Jadav <raagjadav@gmail.com>
Subject: [PATCH 2/2] regulator: act8945a: get rid of redundant structure
Date: Mon, 5 Jun 2023 16:18:30 +0530 [thread overview]
Message-ID: <20230605104830.68552-2-raagjadav@gmail.com> (raw)
In-Reply-To: <20230605104830.68552-1-raagjadav@gmail.com>
Remove struct act8945a_pmic, as we no longer need drvdata.
Signed-off-by: Raag Jadav <raagjadav@gmail.com>
---
drivers/regulator/act8945a-regulator.c | 29 ++++++++------------------
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c
index bd54d76efcbc..73504253acc9 100644
--- a/drivers/regulator/act8945a-regulator.c
+++ b/drivers/regulator/act8945a-regulator.c
@@ -67,10 +67,6 @@ enum {
ACT8945A_ID_LDO4,
};
-struct act8945a_pmic {
- struct regmap *regmap;
-};
-
static const struct linear_range act8945a_voltage_ranges[] = {
REGULATOR_LINEAR_RANGE(600000, 0, 23, 25000),
REGULATOR_LINEAR_RANGE(1200000, 24, 47, 50000),
@@ -301,17 +297,13 @@ static int act8945a_pmic_probe(struct platform_device *pdev)
{
struct regulator_config config = { };
const struct regulator_desc *regulators;
- struct act8945a_pmic *act8945a;
struct regulator_dev *rdev;
+ struct regmap *regmap;
int i, num_regulators;
bool voltage_select;
- act8945a = devm_kzalloc(&pdev->dev, sizeof(*act8945a), GFP_KERNEL);
- if (!act8945a)
- return -ENOMEM;
-
- act8945a->regmap = dev_get_regmap(pdev->dev.parent, NULL);
- if (!act8945a->regmap) {
+ regmap = dev_get_regmap(pdev->dev.parent, NULL);
+ if (!regmap) {
dev_err(&pdev->dev,
"could not retrieve regmap from parent device\n");
return -EINVAL;
@@ -330,7 +322,6 @@ static int act8945a_pmic_probe(struct platform_device *pdev)
config.dev = &pdev->dev;
config.dev->of_node = pdev->dev.parent->of_node;
- config.driver_data = act8945a;
for (i = 0; i < num_regulators; i++) {
rdev = devm_regulator_register(&pdev->dev, ®ulators[i],
&config);
@@ -342,33 +333,31 @@ static int act8945a_pmic_probe(struct platform_device *pdev)
}
}
- platform_set_drvdata(pdev, act8945a);
-
/* Unlock expert registers. */
- return regmap_write(act8945a->regmap, ACT8945A_SYS_UNLK_REGS, 0xef);
+ return regmap_write(regmap, ACT8945A_SYS_UNLK_REGS, 0xef);
}
-static int __maybe_unused act8945a_suspend(struct device *pdev)
+static int __maybe_unused act8945a_suspend(struct device *dev)
{
- struct act8945a_pmic *act8945a = dev_get_drvdata(pdev);
+ struct regmap *regmap = dev_get_regmap(dev->parent, NULL);
/*
* Ask the PMIC to enter the suspend mode on the next PWRHLD
* transition.
*/
- return regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x42);
+ return regmap_write(regmap, ACT8945A_SYS_CTRL, 0x42);
}
static SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
static void act8945a_pmic_shutdown(struct platform_device *pdev)
{
- struct act8945a_pmic *act8945a = platform_get_drvdata(pdev);
+ struct regmap *regmap = dev_get_regmap(pdev->dev.parent, NULL);
/*
* Ask the PMIC to shutdown everything on the next PWRHLD transition.
*/
- regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x0);
+ regmap_write(regmap, ACT8945A_SYS_CTRL, 0x0);
}
static struct platform_driver act8945a_pmic_driver = {
--
2.25.1
next prev parent reply other threads:[~2023-06-05 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 10:48 [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode Raag Jadav
2023-06-05 10:48 ` Raag Jadav [this message]
2023-06-05 12:16 ` Mark Brown
2023-06-05 14:31 ` Raag Jadav
2023-06-05 14:44 ` Mark Brown
2023-06-05 16:16 ` Raag Jadav
2023-06-05 16:30 ` Mark Brown
2023-06-06 7:00 ` Raag Jadav
2023-06-06 12:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605104830.68552-2-raagjadav@gmail.com \
--to=raagjadav@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox