From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A5A3C7EE24 for ; Mon, 5 Jun 2023 13:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232359AbjFEN7I (ORCPT ); Mon, 5 Jun 2023 09:59:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbjFEN7G (ORCPT ); Mon, 5 Jun 2023 09:59:06 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7E094; Mon, 5 Jun 2023 06:59:05 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-30aebe2602fso3986097f8f.3; Mon, 05 Jun 2023 06:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685973544; x=1688565544; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=iCDndboYofs1euZozUPZ+wnkvppaYLsmW/x22Y7k9M0=; b=pvV+1QGkdTwyZVyWQBE4H57sf4SvOHNIIJwSSDPCX5sbiigvDQx1XAd9yORmbpC0I/ IgjijCwGDme1HiuHePb3QmZAImM7Tl0y4988DbqOL+QRMGgfuNf/gjjp1TD+3Bs9/QMF I1+hUybPmKRwVRvRKyy6xSec8WUJT4or8unei0NCZWL7hPRX1lSGF/owrdy8n32y4KmD 3v3kuRhQSau4a5Nbs9z7sYNijM++d8pxDB5w7bcJ591ZXeYRhJtGz8LmvBR4/IaNlZOn yWxN+HGJiU4g/QZ8JOQ/THt7CztMijvUXp2/uqopPTCQSHie9GdEV0pkeSLGiW30rISP /8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685973544; x=1688565544; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iCDndboYofs1euZozUPZ+wnkvppaYLsmW/x22Y7k9M0=; b=EJDhFV6YsUh7JP38S5f1+20nwpSJ0DrSs5l1bjA2D6fYzNIMpGtI/KQn9A9ku0AgoL SjtAp4pamFHafBRW1GHbl6PmT68NkqM+sxzuwYiUV65AaAsPvKszloWgX/bBH5XA4maI BV//4N+9pkt0XkzXpSyEv6aSTSVN+u8+4IW+0Sy/GKiVdxd4Qs70jk5P0fCUNiPGz7fn w5Z+DYMdjrQwMALLZNN79qAVKlG8zemGR0IJMD+t4slLeh9xE23u2plzXoBYIBpz2JLJ KqO5VS1Deerts9P7Kj5dmwtzGC7bOUbHJ5QDmdvdVAml9AisMbGBfVYDQ0lehjIWZV2v W8ew== X-Gm-Message-State: AC+VfDyjxNb4zUWApKJGym+jZ1+9ivzl7O3NfBzj+/10BR8u9T5aZrZX tKa5bEO6NCpK/O1+p7dBEF4= X-Google-Smtp-Source: ACHHUZ78YsjSY1NfptdogV0zvYdPfYdfyz8LlSiElz6nTgR68VFQMWzCSU8irsroAhjJD8wIyhd0Rw== X-Received: by 2002:adf:fed2:0:b0:306:368d:8a1c with SMTP id q18-20020adffed2000000b00306368d8a1cmr4857559wrs.45.1685973543846; Mon, 05 Jun 2023 06:59:03 -0700 (PDT) Received: from debian ([89.238.191.199]) by smtp.gmail.com with ESMTPSA id j14-20020adff54e000000b0030aec5e020fsm9886635wrp.86.2023.06.05.06.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 06:59:03 -0700 (PDT) Date: Mon, 5 Jun 2023 15:58:23 +0200 From: Richard Gobert To: Alexander Lobakin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lixiaoyan@google.com, lucien.xin@gmail.com, alexanderduyck@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/1] gro: decrease size of CB Message-ID: <20230605135821.GA8361@debian> References: <20230601160924.GA9194@debian> <3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I hope you've checked that there's no difference in object code with and > w/o `inline`? Sometimes the compilers do weird things and stop inlining > oneliners if they're used more than once. skb_gro_reset_offset() is > marked `inline` exactly due to that =\ Checked on standard x86-64 and arm64 gcc compilers. Would you check any other cases?