From: Raag Jadav <raagjadav@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode
Date: Mon, 5 Jun 2023 20:01:03 +0530 [thread overview]
Message-ID: <20230605143103.GA3068@pc> (raw)
In-Reply-To: <04b8fa24-e5a8-4871-a397-f1c0c886449a@sirena.org.uk>
On Mon, Jun 05, 2023 at 01:16:33PM +0100, Mark Brown wrote:
> On Mon, Jun 05, 2023 at 04:18:29PM +0530, Raag Jadav wrote:
>
> > Convert ->get_mode() and ->set_mode() hooks to read/write operating mode
> > from/to hardware instead of relying on driver memory.
>
> Why is this change being made - what is the benefit here?
Original implementation uses drvdata to load/store
operating mode for the regulator.
This change doesn't really add anything new.
It is just to make sure that the driver is in sync
with the current state of affairs in the hardware
instead of relying on locally stored status in the memory.
> > While at it, map fixed-frequency PWM regulators to REGULATOR_MODE_FAST.
>
> Don't combine multiple changes into a single patch, this just makes
> everything harder to review.
Will split in v2.
Cheers,
Raag
next prev parent reply other threads:[~2023-06-05 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 10:48 [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode Raag Jadav
2023-06-05 10:48 ` [PATCH 2/2] regulator: act8945a: get rid of redundant structure Raag Jadav
2023-06-05 12:16 ` [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode Mark Brown
2023-06-05 14:31 ` Raag Jadav [this message]
2023-06-05 14:44 ` Mark Brown
2023-06-05 16:16 ` Raag Jadav
2023-06-05 16:30 ` Mark Brown
2023-06-06 7:00 ` Raag Jadav
2023-06-06 12:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605143103.GA3068@pc \
--to=raagjadav@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox