From: Raag Jadav <raagjadav@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode
Date: Tue, 6 Jun 2023 12:30:07 +0530 [thread overview]
Message-ID: <20230606070007.GA4691@pc> (raw)
In-Reply-To: <42423085-2c9c-47f6-9588-3e2260da7cfa@sirena.org.uk>
On Mon, Jun 05, 2023 at 05:30:36PM +0100, Mark Brown wrote:
> On Mon, Jun 05, 2023 at 09:46:14PM +0530, Raag Jadav wrote:
> > On Mon, Jun 05, 2023 at 03:44:37PM +0100, Mark Brown wrote:
>
> > > It's also removing a cache so we need to talk to the hardware more often
> > > which doesn't seem like a win. If there's a bootstapping problem then
> > > shouldn't we just read once at startup? If there's no problem what's
> > > the advantage?
>
> > Well, there could be cases of access which are done
> > outside of driver context or hardware failure,
> > which are not really ideal but I've faced such problems
> > a while back, so just decided to share it.
>
> If we have those then we've got a bigger problem, for example we might
> switch to a lower power mode which can't support the load we're trying
> to get the consumer to run.
Yes, but in such cases it will atleast report whatever mode currently
set in the hardware and not the incorrect one stored locally in the memory,
and this way I think we have a better chance of finding out that
there indeed is a problem.
Cheers,
Raag
next prev parent reply other threads:[~2023-06-06 7:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 10:48 [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode Raag Jadav
2023-06-05 10:48 ` [PATCH 2/2] regulator: act8945a: get rid of redundant structure Raag Jadav
2023-06-05 12:16 ` [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode Mark Brown
2023-06-05 14:31 ` Raag Jadav
2023-06-05 14:44 ` Mark Brown
2023-06-05 16:16 ` Raag Jadav
2023-06-05 16:30 ` Mark Brown
2023-06-06 7:00 ` Raag Jadav [this message]
2023-06-06 12:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606070007.GA4691@pc \
--to=raagjadav@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox