From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
Peter Xu <peterx@redhat.com>, "Shuah Khan" <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>, <linux-mm@kvack.org>,
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 07/11] selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h
Date: Tue, 6 Jun 2023 00:16:33 -0700 [thread overview]
Message-ID: <20230606071637.267103-8-jhubbard@nvidia.com> (raw)
In-Reply-To: <20230606071637.267103-1-jhubbard@nvidia.com>
This fixes a real bug, too, because xstate_size() was assuming that
the stack variable xstate_size was initialized to zero. That's not
guaranteed nor even especially likely.
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Peter Xu <peterx@redhat.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
tools/testing/selftests/mm/pkey-x86.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/pkey-x86.h b/tools/testing/selftests/mm/pkey-x86.h
index 72c14cd3ddc7..e32ae8a1cd99 100644
--- a/tools/testing/selftests/mm/pkey-x86.h
+++ b/tools/testing/selftests/mm/pkey-x86.h
@@ -132,7 +132,7 @@ int pkey_reg_xstate_offset(void)
unsigned int ecx;
unsigned int edx;
int xstate_offset;
- int xstate_size;
+ int xstate_size = 0;
unsigned long XSTATE_CPUID = 0xd;
int leaf;
--
2.40.1
next prev parent reply other threads:[~2023-06-06 7:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:16 [PATCH v3 00/11] A minor flurry of selftest/mm fixes John Hubbard
2023-06-06 7:16 ` [PATCH v3 01/11] selftests/mm: fix uffd-stress unused function warning John Hubbard
2023-06-06 7:46 ` Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 02/11] selftests/mm: fix unused variable warnings in hugetlb-madvise.c, migration.c John Hubbard
2023-06-06 7:48 ` Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 03/11] selftests/mm: fix "warning: expression which evaluates to zero..." in mlock2-tests.c John Hubbard
2023-06-06 7:49 ` Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 04/11] selftests/mm: fix invocation of tests that are run via shell scripts John Hubbard
2023-06-06 7:51 ` Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 05/11] selftests/mm: .gitignore: add mkdirty, va_high_addr_switch John Hubbard
2023-06-06 7:52 ` Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 06/11] selftests/mm: fix two -Wformat-security warnings in uffd builds John Hubbard
2023-06-06 7:54 ` Muhammad Usama Anjum
2023-06-06 7:16 ` John Hubbard [this message]
2023-06-06 7:55 ` [PATCH v3 07/11] selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 08/11] selftests/mm: fix build failures due to missing MADV_COLLAPSE John Hubbard
2023-06-06 7:55 ` Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 09/11] selftests/mm: move certain uffd*() routines from vm_util.c to uffd-common.c John Hubbard
2023-06-06 7:56 ` Muhammad Usama Anjum
2023-06-06 7:16 ` [PATCH v3 10/11] Documentation: kselftest: "make headers" is a prerequisite John Hubbard
2023-06-06 7:57 ` Muhammad Usama Anjum
2023-07-10 14:20 ` Mark Brown
2023-06-06 7:16 ` [PATCH v3 11/11] selftests: error out if kernel header files are not yet built John Hubbard
2023-06-06 7:38 ` Muhammad Usama Anjum
2023-06-06 20:10 ` John Hubbard
2023-06-07 5:37 ` Muhammad Usama Anjum
2023-06-06 7:57 ` Muhammad Usama Anjum
2023-11-03 12:16 ` Peter Zijlstra
2023-11-03 12:22 ` David Hildenbrand
2023-11-03 12:46 ` Peter Zijlstra
2023-11-03 12:59 ` David Hildenbrand
2023-11-03 13:00 ` David Hildenbrand
2023-11-03 13:08 ` Peter Zijlstra
2023-12-08 15:14 ` Peter Zijlstra
2023-12-08 15:21 ` David Hildenbrand
2023-12-08 20:29 ` John Hubbard
2023-12-08 22:10 ` Peter Zijlstra
2023-12-09 1:39 ` John Hubbard
2023-12-08 12:44 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606071637.267103-8-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nathan@kernel.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox