From: Oleg Nesterov <oleg@redhat.com>
To: Wander Lairson Costa <wander@redhat.com>
Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Brian Cain <bcain@quicinc.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Stafford Horne <shorne@gmail.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrei Vagin <avagin@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Yu Zhao <yuzhao@google.com>, Alexey Gladkov <legion@kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Yang Shi <shy828301@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
Hu Chunyu <chuhu@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Luis Goncalves <lgoncalv@redhat.com>
Subject: Re: [PATCH v9] kernel/fork: beware of __put_task_struct calling context
Date: Tue, 6 Jun 2023 22:39:59 +0200 [thread overview]
Message-ID: <20230606203958.GC18866@redhat.com> (raw)
In-Reply-To: <CAAq0SU=A5j2-GF80Thi2vm8W+_AUquj6t+QK7cnWLz1jKEA4zg@mail.gmail.com>
On 06/05, Wander Lairson Costa wrote:
>
> Thanks. I found an unrelated earlier splat in the console code. That's
> why I couldn't reproduce it in the stock kernel.
As expected...
So... Not sure what can I say ;) can you verify that this patch doesn't solve
the issues with CONFIG_PROVE_RAW_LOCK_NESTING pointed out by Sebastian? Using
stress-ng or anything else.
This is not that bad, unless I am totally confused the current code (without
your patch) has the same problem (otherwise we wouldn't need this fix).
But perhaps you can make 2/2 which adds the DEFINE_WAIT_OVERRIDE_MAP() hack
as Peter suggested?
Oleg.
next prev parent reply other threads:[~2023-06-06 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 19:14 [PATCH v9] kernel/fork: beware of __put_task_struct calling context Wander Lairson Costa
2023-05-16 19:24 ` Matthew Wilcox
2023-05-16 21:05 ` Andrew Morton
2023-05-16 21:41 ` Matthew Wilcox
2023-05-16 22:50 ` Andrew Morton
2023-05-17 15:26 ` Oleg Nesterov
2023-05-17 16:57 ` Wander Lairson Costa
2023-05-29 12:22 ` Oleg Nesterov
2023-06-01 17:45 ` Wander Lairson Costa
2023-06-01 18:13 ` Oleg Nesterov
2023-06-01 18:23 ` Wander Lairson Costa
2023-06-02 17:34 ` Oleg Nesterov
2023-06-05 11:24 ` Wander Lairson Costa
2023-06-06 20:39 ` Oleg Nesterov [this message]
2023-06-09 19:07 ` Wander Lairson Costa
2023-06-02 17:39 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606203958.GC18866@redhat.com \
--to=oleg@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=bcain@quicinc.com \
--cc=bigeasy@linutronix.de \
--cc=bristot@kernel.org \
--cc=chuhu@redhat.com \
--cc=ebiederm@xmission.com \
--cc=legion@kernel.org \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rostedt@goodmis.org \
--cc=shorne@gmail.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
--cc=vschneid@redhat.com \
--cc=wander@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox