From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Kees Cook <keescook@chromium.org>,
Sasha Levin <sashal@kernel.org>, Tom Gall <tom.gall@linaro.org>
Subject: Re: [PATCH] checkpatch: check for missing Fixes tags
Date: Tue, 6 Jun 2023 12:18:46 +0200 [thread overview]
Message-ID: <2023060628-sizzle-valuables-b782@gregkh> (raw)
In-Reply-To: <ZH7uo6ph8nhidxcV@moroto>
On Tue, Jun 06, 2023 at 11:30:27AM +0300, Dan Carpenter wrote:
> This check looks for common words that probably indicate a patch
> is a fix. For now the regex is:
>
> (BUG: KASAN|Call Trace:|syzkaller|stable\@)
>
> Why are stable patches encouraged to have a fixes tag? Some people mark
> their stable patches as "# 5.10" etc. This is not as useful as a Fixes
> tag. The Fixes tag helps in review. It helps people to not cherry-pick
> buggy patches without also cherry-picking the fix.
>
> Also if a bug affects the 5.7 kernel some people will round it up to
> 5.10+ because 5.7 is not supported on kernel.org. It's possible the Bad
> Binder bug was caused by this sort of gap where companies outside of
> kernel.org are supporting different kernels from kernel.org?
>
> Should it be counted as a Fix when a patch just silences harmless
> WARN_ON() stack trace. Yes. Definitely.
>
> Is silencing compiler warnings a fix? It seems unfair to the original
> authors, but we use -Werror now, and warnings break the build so let's
> just add Fixes tags for those. I tell people that silencing static
> checker warnings is not a fix but the rules on this vary by subsystem.
>
> Is fixing a minor LTP issue (Linux Test Project) a fix? Probably? It's
> hard to know what to do if the LTP test has technically always been
> broken.
>
> One clear false positive from this check is when a patch updated the
> debug output and the commit message included before and after Call
> Traces. Sometimes you should just ignore checkpatch.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Nice!
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2023-06-06 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 8:30 [PATCH] checkpatch: check for missing Fixes tags Dan Carpenter
2023-06-06 10:18 ` Greg Kroah-Hartman [this message]
2023-06-06 11:39 ` Thorsten Leemhuis
2023-06-06 15:11 ` Joe Perches
2023-06-06 15:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023060628-sizzle-valuables-b782@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=sashal@kernel.org \
--cc=tom.gall@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox