[PATCH] drivers: usb: musb: musb_gadget: Removed unneeded code

[PATCH] drivers: usb: musb: musb_gadget: Removed unneeded code

[Neel Chakraborty]

Removed the static int musb_gadget_vbus_session function as it was
doing nothing.It has reduced 13 lines of code

Signed-off-by: Neel Chakraborty <neelchakrabortykernelwork@gmail.com>
---
 drivers/usb/musb/musb_gadget.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index 31c44325e828..3cb7fc4c84ed 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1612,19 +1612,6 @@ static void musb_pullup(struct musb *musb, int is_on)
 	musb_writeb(musb->mregs, MUSB_POWER, power);
 }
 
-#if 0
-static int musb_gadget_vbus_session(struct usb_gadget *gadget, int is_active)
-{
-	musb_dbg(musb, "<= %s =>\n", __func__);
-
-	/*
-	 * FIXME iff driver's softconnect flag is set (as it is during probe,
-	 * though that can clear it), just musb_pullup().
-	 */
-
-	return -EINVAL;
-}
-#endif
 
 static int musb_gadget_vbus_draw(struct usb_gadget *gadget, unsigned mA)
 {
-- 
2.40.1

Re: [PATCH] drivers: usb: musb: musb_gadget: Removed unneeded code

[Greg KH]

On Tue, Jun 06, 2023 at 03:50:58PM +0530, Neel Chakraborty wrote:
> Removed the static int musb_gadget_vbus_session function as it was
> doing nothing.It has reduced 13 lines of code
> 
> Signed-off-by: Neel Chakraborty <neelchakrabortykernelwork@gmail.com>
> ---
>  drivers/usb/musb/musb_gadget.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> index 31c44325e828..3cb7fc4c84ed 100644
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -1612,19 +1612,6 @@ static void musb_pullup(struct musb *musb, int is_on)
>  	musb_writeb(musb->mregs, MUSB_POWER, power);
>  }
>  
> -#if 0
> -static int musb_gadget_vbus_session(struct usb_gadget *gadget, int is_active)
> -{
> -	musb_dbg(musb, "<= %s =>\n", __func__);
> -
> -	/*
> -	 * FIXME iff driver's softconnect flag is set (as it is during probe,
> -	 * though that can clear it), just musb_pullup().
> -	 */
> -
> -	return -EINVAL;
> -}
> -#endif
>  
>  static int musb_gadget_vbus_draw(struct usb_gadget *gadget, unsigned mA)
>  {
> -- 
> 2.40.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot