From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF97C7EE24 for ; Tue, 6 Jun 2023 10:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235078AbjFFKCZ (ORCPT ); Tue, 6 Jun 2023 06:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235716AbjFFKCO (ORCPT ); Tue, 6 Jun 2023 06:02:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62C7CE78; Tue, 6 Jun 2023 03:02:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC2EB62598; Tue, 6 Jun 2023 10:02:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BA03C433EF; Tue, 6 Jun 2023 10:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686045729; bh=1IoFuwmoNSSKAwyxIlVTyvXm8uDl4GdCtAIidncLBB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ye+qgjyDzSkgkebwek9jswghyGjYlglS9wXkb33X7e7Ie/Uv2rWxBZrqIFA8/5Q44 Qt0FxrJOYXfkdLJoMtiDhUHRvRdzxz6ZLxYeCw37b6LB/jQMGOb3jCer3xDknF4xfX aeT8jODlrzBENDSIk9nb0283Ga10Q7tD2ugaLP7M= Date: Tue, 6 Jun 2023 12:02:06 +0200 From: Greg KH To: Neel Chakraborty Cc: b-liu@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: usb: musb: musb_gadget: fixed coding style issues and removed unneeded code Message-ID: <2023060644-countdown-employer-2af9@gregkh> References: <20230606065921.997102-1-neelchakrabortykernelwork@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606065921.997102-1-neelchakrabortykernelwork@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2023 at 12:29:21PM +0530, Neel Chakraborty wrote: > Fixed a few coding style issues > Removed the static int musb_gadget_vbus_session function as it was > doing nothing. > > Signed-off-by: Neel Chakraborty > --- > drivers/usb/musb/musb_gadget.c | 38 +++++++++++----------------------- > 1 file changed, 12 insertions(+), 26 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot