* [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask
@ 2023-06-07 2:05 Jiasheng Jiang
2023-06-07 5:07 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2023-06-07 2:05 UTC (permalink / raw)
To: hyun.kwon, laurent.pinchart, airlied, daniel, michal.simek
Cc: dri-devel, linux-arm-kernel, linux-kernel, Jiasheng Jiang
Add check for dma_set_mask() and return the error if it fails.
Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index bab862484d42..068413be6527 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev)
dpsub->dev = &pdev->dev;
platform_set_drvdata(pdev, dpsub);
- dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT));
+ ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT));
+ if (ret)
+ return ret;
/* Try the reserved memory. Proceed if there's none. */
of_reserved_mem_device_init(&pdev->dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask
2023-06-07 2:05 [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask Jiasheng Jiang
@ 2023-06-07 5:07 ` Laurent Pinchart
2023-06-07 9:38 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2023-06-07 5:07 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: hyun.kwon, airlied, daniel, michal.simek, dri-devel,
linux-arm-kernel, linux-kernel, Tomi Valkeinen
Hello Jiasheng,
Thank you for the patch.
On Wed, Jun 07, 2023 at 10:05:29AM +0800, Jiasheng Jiang wrote:
> Add check for dma_set_mask() and return the error if it fails.
>
> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index bab862484d42..068413be6527 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev)
> dpsub->dev = &pdev->dev;
> platform_set_drvdata(pdev, dpsub);
>
> - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT));
> + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT));
> + if (ret)
> + return ret;
This seems reasonable.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tomi, would you be able to quickly test this ?
>
> /* Try the reserved memory. Proceed if there's none. */
> of_reserved_mem_device_init(&pdev->dev);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask
2023-06-07 5:07 ` Laurent Pinchart
@ 2023-06-07 9:38 ` Tomi Valkeinen
0 siblings, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2023-06-07 9:38 UTC (permalink / raw)
To: Laurent Pinchart, Jiasheng Jiang
Cc: hyun.kwon, airlied, daniel, michal.simek, dri-devel,
linux-arm-kernel, linux-kernel
On 07/06/2023 08:07, Laurent Pinchart wrote:
> Hello Jiasheng,
>
> Thank you for the patch.
>
> On Wed, Jun 07, 2023 at 10:05:29AM +0800, Jiasheng Jiang wrote:
>> Add check for dma_set_mask() and return the error if it fails.
>>
>> Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index bab862484d42..068413be6527 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev)
>> dpsub->dev = &pdev->dev;
>> platform_set_drvdata(pdev, dpsub);
>>
>> - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT));
>> + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT));
>> + if (ret)
>> + return ret;
>
> This seems reasonable.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Tomi, would you be able to quickly test this ?
Works for me.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-07 9:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 2:05 [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask Jiasheng Jiang
2023-06-07 5:07 ` Laurent Pinchart
2023-06-07 9:38 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox