public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: "Pali Rohár" <pali@kernel.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Mark Gross" <markgross@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Kai-Heng Feng" <kai.heng.feng@canonical.com>
Subject: Re: [PATCH] platform/x86: dell-laptop: Add drm module soft dependency
Date: Wed, 7 Jun 2023 08:47:32 +0100	[thread overview]
Message-ID: <20230607074732.GA31666@srcf.ucam.org> (raw)
In-Reply-To: <CAFv23Q==r4newMXE3OWavRSRt-bEi5-qR0Vo-5HGLw4r9J36MA@mail.gmail.com>

On Wed, Jun 07, 2023 at 03:39:33PM +0800, AceLan Kao wrote:

> What do you think if we unregister backlight devices if the backlight type
> is larger than the current registered one.
> Do this check in backlight_device_register() and unregister backlight
> devices by the order raw(1) > platform(2) > firmware(3)
> And maybe introduce a sticky bit into the backlight device if the backlight
> driver doesn't want to be removed.

Hans looked at doing this, but there were some awkward corner cases. 
When we first introduced this functionality, firmware was preferred to 
platform was preferred to raw - but on Intel, at least, this behaviour 
changed with later versions of Windows. I don't think there's a single 
static policy that works, I think you need to pay attention to the hints 
the platform gives you. How does Windows know which interface to use on 
this platform? The simplest solution may actually just be for 
dell-laptop to refuse to register a backlight if the platform claims to 
be Windows 8 or later.

  reply	other threads:[~2023-06-07  7:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07  3:43 [PATCH] platform/x86: dell-laptop: Add drm module soft dependency AceLan Kao
2023-06-07  4:20 ` Matthew Garrett
2023-06-07  5:19   ` AceLan Kao
2023-06-07  5:27     ` Matthew Garrett
2023-06-07  6:13       ` AceLan Kao
2023-06-07  6:23         ` Matthew Garrett
2023-06-07  6:56           ` Pali Rohár
2023-06-07  7:39             ` AceLan Kao
2023-06-07  7:47               ` Matthew Garrett [this message]
2023-06-07 19:16                 ` Hans de Goede
2023-06-08  3:04                   ` AceLan Kao
2023-06-08  9:16                     ` Hans de Goede
2023-06-13  7:30                       ` AceLan Kao
2023-06-13  8:54                         ` Hans de Goede
2023-06-15  1:53                           ` AceLan Kao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607074732.GA31666@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=acelan.kao@canonical.com \
    --cc=hdegoede@redhat.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=pali@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox