From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 73C74C7EE23
	for <linux-kernel@archiver.kernel.org>; Wed,  7 Jun 2023 17:26:18 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231716AbjFGR0R (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 7 Jun 2023 13:26:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59122 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231545AbjFGR0D (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Jun 2023 13:26:03 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 970B81FE9
        for <linux-kernel@vger.kernel.org>; Wed,  7 Jun 2023 10:26:02 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 33EBE641ED
        for <linux-kernel@vger.kernel.org>; Wed,  7 Jun 2023 17:26:02 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05812C433D2;
        Wed,  7 Jun 2023 17:26:00 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1686158761;
        bh=0MBhuEUX2bktmVFKRPGnv8oU9W5tm0XrwIeAW9OBqu4=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=NYJztc6K5jZaEpT5qmYChibBOYzwSAkpmz4luHH2EERw0PJbUy4NdUK7sOHmMohEv
         L4Y7jZiccYhyhFR5ioEP01GXWEyxpDJ73Gab/BxVRJhCWxnFAvzE29QxtsB3IuT1xn
         qTcuRgtm/jMMrfC+i53EtgpTUIBBrnLMh+sI0NfGT4IFKTnbOOgHyY6BB+ny035F9E
         av80Tcccr/PaZaKHCB3HTiybgCAWkD4ePOn5L4H0tXwCaTFgXNFkqzK4UldjZtsxwy
         rbwwSEegzCShGku9llVhj8mpPI6xq3GpFvw8RP/8sQpd1zt7NT2VqVpvzleaooJKow
         euaKcvwu3sxTw==
Date:   Wed, 7 Jun 2023 10:26:00 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        Boris Pismenny <borisp@nvidia.com>,
        John Fastabend <john.fastabend@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 14/14] tls/device: Convert
 tls_device_sendpage() to use MSG_SPLICE_PAGES
Message-ID: <20230607102600.07d16cf0@kernel.org>
In-Reply-To: <20230607140559.2263470-15-dhowells@redhat.com>
References: <20230607140559.2263470-1-dhowells@redhat.com>
        <20230607140559.2263470-15-dhowells@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed,  7 Jun 2023 15:05:59 +0100 David Howells wrote:
> Convert tls_device_sendpage() to use sendmsg() with MSG_SPLICE_PAGES rather
> than directly splicing in the pages itself.  With that, the tls_iter_offset
> union is no longer necessary and can be replaced with an iov_iter pointer
> and the zc_page argument to tls_push_data() can also be removed.
> 
> This allows ->sendpage() to be replaced by something that can handle
> multiple multipage folios in a single transaction.

Acked-by: Jakub Kicinski <kuba@kernel.org>