Re: [PATCH net-next v5 12/14] tls/sw: Convert tls_sw_sendpage() to use MSG_SPLICE_PAGES

Jakub Kicinski
2023-06-07T17:20:30Z

On Wed, 7 Jun 2023 15:05:57 +0100 David Howells wrote:
> Convert tls_sw_sendpage() and tls_sw_sendpage_locked() to use sendmsg()
> with MSG_SPLICE_PAGES rather than directly splicing in the pages itself.
>
> [!] Note that tls_sw_sendpage_locked() appears to have the wrong locking
> upstream. I think the caller will only hold the socket lock, but it
> should hold tls_ctx->tx_lock too.
>
> This allows ->sendpage() to be replaced by something that can handle
> multiple multipage folios in a single transaction.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>