Re: [PATCH 7/7] watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCH

Petr Mladek
2023-06-08T13:48:11Z

On Wed 2023-06-07 16:37:10, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:26 AM Petr Mladek <pmladek@suse.com> wrote:
> >
> > @@ -1102,6 +1103,14 @@ config HARDLOCKUP_DETECTOR_BUDDY
> > depends on !HAVE_HARDLOCKUP_DETECTOR_ARCH
> > select HARDLOCKUP_DETECTOR_COUNTS_HRTIMER
> >
> > +config HARDLOCKUP_DETECTOR_ARCH
> > + bool
> > + depends on HARDLOCKUP_DETECTOR
> > + depends on HAVE_HARDLOCKUP_DETECTOR_ARCH
> > + help
> > + The arch-specific implementation of the hardlockup detector is
> > + available.
>
> nit: "is available" makes it sound a bit too much like a "have"
> version. Maybe "The arch-specific implementation of the hardlockup
> detector will be used" or something like that?

Makes sense. Will do this change in v2.

> Otherise:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks,
Petr