RE: [PATCH v3 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY

Stanley Chang[昌育德]
2023-06-08T09:28:46Z

> > I only control a register, it is not needed a driver of power domain.
>
> Aren't many power domains just a registers? What about other drivers?
> Don't you want in other driver control LDO of something else? And in other
> something else?

I will use power domain to instead this.

> > Would "port" be more appropriate?
> >
> > For example,
> > Using phy@0 and phy@1:
> > usb_port1_usb2phy: usb-phy@13c14 {
> > compatible = "realtek,rtd1395-usb2phy", "realtek,usb2phy";
> > reg = <0x132c4 0x4>, <0x31280 0x8>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > #phy-cells = <0>;
> > realtek,usb-ctrl = <&usb_ctrl>;
> >
> > phy@0 {
> > reg = <0>;
>
> So such child is a NAK... you have nothing here. But it's unrelated topic.
Here is for simple, so some items ignore.

> > };
> > phy@1 {
> > reg = <1>;
> > };
> > };
> >
> > Change: port@0 and port@1
> > usb_port1_usb2phy: usb-phy@13c14 {
> > compatible = "realtek,rtd1395-usb2phy", "realtek,usb2phy";
> > reg = <0x132c4 0x4>, <0x31280 0x8>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > #phy-cells = <0>;
> > realtek,usb-ctrl = <&usb_ctrl>;
> >
> > prot@0 {
> > reg = <0>;
> > };
> > port@1 {
> > reg = <1>;
> > };
> > };
>
> This is not the answer. This is the provider. How do you reference it from the
> consumer.

> Upstream your entire DTS. It's frustrating to try to understand your DTS from
> pieces of information you are sharing. Also very time consuming and you are
> not the only one sending patches for review...

Sorry to take up a lot of your time.
Apparently I don't know enough about dts.
I will reference more device tree document to understand the relating between DTS and hardware.

Thanks,
Stanley