Re: [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY

Krzysztof Kozlowski
2023-06-08T07:50:35Z

On 08/06/2023 09:32, Stanley Chang[昌育德] wrote:
>>> +examples:
>>> + - |
>>> + usb_port2_usb3phy: usb-phy@13e10 {
>>> + compatible = "realtek,rtd1319d-usb3phy", "realtek,usb3phy";
>>> + reg = <0x13e10 0x4>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + #phy-cells = <0>;
>>> +
>>> + phy@0 {
>>> + reg = <0>;
>>> + realtek,param =
>>> + <0x01 0xac8c>,
>>> + <0x06 0x0017>,
>>
>> First, this is matrix, not uint8 array. Second, 0xac8c is past 16 bits long, not 8.
>> Third, you put some magic register programming to DT.
>> Please don't. Drop all this from DT.
>
> realtek,param is an uint32-matrx.
> I will revised the type.

Drop the property. It is not explained and not justified to be in DT.

Best regards,
Krzysztof