RE: [PATCH v3 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY

Stanley Chang[昌育德]
2023-06-08T08:02:46Z

> >>
> >> This needs to be specific. What the heck is "PHY parameter"?
> >>
> > It contains more parameters
> > page0 has 16 parameters
> > page1 has 8 parameters
> > page2 has 8 parameters
> > It's tedious if we list them all.
>
> Sure, if you prefer not to list them, then they should be removed from DT.
>
> > And we only set the part that differs from the default.
> > It's hard to explain which parameters were changed because each platform is
> different.
>
> If this is phy tuning per board, you need to explain and justify them.
> If this is per platform, then drop it - not even needed, because you have
> compatible for this.
>
Okay, I try to specify by the compatible.

Thanks,
Stanley