From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6501C7EE23 for ; Thu, 8 Jun 2023 11:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232971AbjFHLCD (ORCPT ); Thu, 8 Jun 2023 07:02:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235157AbjFHLBv (ORCPT ); Thu, 8 Jun 2023 07:01:51 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 716472710; Thu, 8 Jun 2023 04:01:22 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4QcLn81PWhz67fjT; Thu, 8 Jun 2023 18:59:08 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 12:01:11 +0100 Date: Thu, 8 Jun 2023 12:01:11 +0100 From: Jonathan Cameron To: Alison Schofield CC: Vishal Verma , Ira Weiny , Dave Jiang , Ben Widawsky , Dan Williams , , , Davidlohr Bueso , Russ Weight Subject: Re: [PATCH v2 2/4] tools/testing/cxl: Fix command effects for inject/clear poison Message-ID: <20230608120111.00003fd2@Huawei.com> In-Reply-To: References: <20230602-vv-fw_update-v2-0-e9e5cd5adb44@intel.com> <20230602-vv-fw_update-v2-2-e9e5cd5adb44@intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Jun 2023 12:18:55 -0700 Alison Schofield wrote: > On Mon, Jun 05, 2023 at 02:20:23PM -0600, Vishal Verma wrote: > > The CXL spec (3.0, section 8.2.9.8.4) Lists Inject Poison and Clear > > Poison as having the effects of "Immediate Data Change". Fix this in the > > mock driver so that the command effect log is populated correctly. > > > > Fixes: 371c16101ee8 ("tools/testing/cxl: Mock the Inject Poison mailbox command") > > Cc: Alison Schofield > > Cc: Dan Williams > > Signed-off-by: Vishal Verma > > Hi Vishal, > I took a look at this, wondering if we should promote it as a 6.4 fix. > I came up with a no. It has no user impact of inject/clear usage in the > mock driver environment. > > Thanks for fixing! > Reviewed-by: Alison Schofield > Agreed on patch and Alison's comment FWIW Reviewed-by: Jonathan Cameron > > > --- > > tools/testing/cxl/test/mem.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c > > index 34b48027b3de..403cd3608772 100644 > > --- a/tools/testing/cxl/test/mem.c > > +++ b/tools/testing/cxl/test/mem.c > > @@ -52,11 +52,11 @@ static struct cxl_cel_entry mock_cel[] = { > > }, > > { > > .opcode = cpu_to_le16(CXL_MBOX_OP_INJECT_POISON), > > - .effect = cpu_to_le16(0), > > + .effect = cpu_to_le16(EFFECT(2)), > > }, > > { > > .opcode = cpu_to_le16(CXL_MBOX_OP_CLEAR_POISON), > > - .effect = cpu_to_le16(0), > > + .effect = cpu_to_le16(EFFECT(2)), > > }, > > }; > > > > > > -- > > 2.40.1 > > >