Re: [PATCH v2 2/4] tools/testing/cxl: Fix command effects for inject/clear poison

Alison Schofield
2023-06-07T19:19:06Z

On Mon, Jun 05, 2023 at 02:20:23PM -0600, Vishal Verma wrote:
> The CXL spec (3.0, section 8.2.9.8.4) Lists Inject Poison and Clear
> Poison as having the effects of "Immediate Data Change". Fix this in the
> mock driver so that the command effect log is populated correctly.
>
> Fixes: 371c16101ee8 ("tools/testing/cxl: Mock the Inject Poison mailbox command")
> Cc: Alison Schofield <alison.schofield@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Hi Vishal,
I took a look at this, wondering if we should promote it as a 6.4 fix.
I came up with a no. It has no user impact of inject/clear usage in the
mock driver environment.

Thanks for fixing!
Reviewed-by: Alison Schofield <alison.schofield@intel.com>

> ---
> tools/testing/cxl/test/mem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index 34b48027b3de..403cd3608772 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -52,11 +52,11 @@ static struct cxl_cel_entry mock_cel[] = {
> },
> {
> .opcode = cpu_to_le16(CXL_MBOX_OP_INJECT_POISON),
> - .effect = cpu_to_le16(0),
> + .effect = cpu_to_le16(EFFECT(2)),
> },
> {
> .opcode = cpu_to_le16(CXL_MBOX_OP_CLEAR_POISON),
> - .effect = cpu_to_le16(0),
> + .effect = cpu_to_le16(EFFECT(2)),
> },
> };
>
>
> --
> 2.40.1
>