From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6070C7EE23 for ; Thu, 8 Jun 2023 16:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235084AbjFHQiw (ORCPT ); Thu, 8 Jun 2023 12:38:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231611AbjFHQiq (ORCPT ); Thu, 8 Jun 2023 12:38:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82331359B; Thu, 8 Jun 2023 09:38:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3C2E64F08; Thu, 8 Jun 2023 16:38:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6FEBC433EF; Thu, 8 Jun 2023 16:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686242297; bh=XEmF6qBGp6AjqZS2pEe6tYr5uN150IJ3qPE+xWoYBKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sXfvdKoNdH+5gGgxF/Lsj+zDYAUgQPESrWgLWz+sGpimJL9NxBqbtKAzl9QtkcJOr cX6jN7u8WOnpN9Dfrp/ZUhmzkVy2L0RAqK8Q/z06nlGYknliPhX0SjnSqvxHfnx8nQ F4I/vHjAz16JXjEGmdszztgfBOifxcY7PD+mKZNDF1W9/IZocpR3rE58eEPbnvrL2o jXf4TGnqEya8SPSb2g56Ukv3iHrVG+OVMi9cUTxBsJ/Jr57HskqsgtKxCfKEiQUERU Bql56CLUYyyAUJYYFRt6YAFX4vZ+EW3BQfIfd4niEs6Jg5i2woQDTD5yk4KhYg89yL Khsv+PUYgYTzg== Date: Thu, 8 Jun 2023 17:38:12 +0100 From: Lee Jones To: Yang Li Cc: pavel@ucw.cz, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which can never be negative Message-ID: <20230608163812.GC3572061@google.com> References: <20230531020238.102684-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230531020238.102684-1-yang.lee@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2023, Yang Li wrote: > The return value from the call to cht_wc_leds_find_freq() is int. > However, the return value is being assigned to an unsigned > int variable 'ctrl', so making it an int. > > Eliminate the following warning: > drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341 > Signed-off-by: Yang Li > --- > drivers/leds/leds-cht-wcove.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks -- Lee Jones [李琼斯]