From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: zhuyinbo <zhuyinbo@loongson.cn>
Cc: Minas Harutyunyan <hminas@synopsys.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v1] usb: dwc2: add pci_device_id driver_data parse support
Date: Thu, 8 Jun 2023 11:11:09 +0200 [thread overview]
Message-ID: <2023060817-tinker-reaction-bbe1@gregkh> (raw)
In-Reply-To: <f086572b-d7c3-43f2-073e-ec35392bdc55@loongson.cn>
On Thu, Jun 08, 2023 at 04:57:04PM +0800, zhuyinbo wrote:
>
>
> 在 2023/6/8 下午4:01, Greg Kroah-Hartman 写道:
> > On Thu, Jun 08, 2023 at 03:54:36PM +0800, zhuyinbo wrote:
> > >
> > > Friendly ping ?
> >
> > For what? I thought a new series was going to be submitted, I don't
> > have anything in my queue to review for this at the moment.
>
>
> I have some comments that need your consent or opinion.
> such as, I have a explanation why I using pci_match_id() in
> dwc2/params.c. Do you agree with my explanation ?
I have no context here, sorry. Remember, we review hundreds of patches
a week, when you cut off all context that makes it impossible to
remember.
Submit your updated patchset based on what you feel is correct and we
can review it from there.
thanks,
greg k-h
next prev parent reply other threads:[~2023-06-08 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 9:22 [PATCH v1] usb: dwc2: add pci_device_id driver_data parse support Yinbo Zhu
2023-05-18 10:32 ` Greg Kroah-Hartman
2023-05-20 3:24 ` zhuyinbo
2023-06-08 7:54 ` zhuyinbo
2023-06-08 8:01 ` Greg Kroah-Hartman
2023-06-08 8:57 ` zhuyinbo
2023-06-08 9:11 ` Greg Kroah-Hartman [this message]
2023-06-09 1:15 ` zhuyinbo
2023-05-18 17:52 ` kernel test robot
2023-05-19 7:13 ` zhuyinbo
2023-05-19 9:49 ` Greg Kroah-Hartman
2023-05-20 3:33 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023060817-tinker-reaction-bbe1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=stern@rowland.harvard.edu \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox