From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE50C7EE29 for ; Fri, 9 Jun 2023 00:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237665AbjFIAJU (ORCPT ); Thu, 8 Jun 2023 20:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235685AbjFIAJS (ORCPT ); Thu, 8 Jun 2023 20:09:18 -0400 Received: from bee.birch.relay.mailchannels.net (bee.birch.relay.mailchannels.net [23.83.209.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61BA22D68 for ; Thu, 8 Jun 2023 17:09:17 -0700 (PDT) X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B36C0101DFA for ; Fri, 9 Jun 2023 00:09:16 +0000 (UTC) Received: from pdx1-sub0-mail-a313.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 51D1510119E for ; Fri, 9 Jun 2023 00:09:16 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1686269356; a=rsa-sha256; cv=none; b=h1DjhUSDWQOxMG7iYjzCMPTtVwG7NoHM0uvaAcb8dkBMOEJdezmR4KWCGkiT3Ifem8X8Xs JrZ5YLx/UIOgV2l7M1hD5F0jgF92je8A8aCY6QDQgiTYlBQF4WuvOStTbIp3LfVB9DUuM/ gaDZp7VquA680w3YvP0ATbqFMoMu8Oh8pNMav/MVgDF828erkSdHVeYvV7V0jIx1i4bfkv JYXeTGrtAjuRhM0chorn8adtqsQvwq5K7otGZNeuBaAdn2r32TxIMIL57a/xeTThJofvei soyZyO7bqbMknaMgDSqmaYaHfVIMUyJ8jgTxQD0k68JJEMwbIBFH7TrpHDRC6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1686269356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lQJUql2528Cy+DS6D/lrrawtBMQvuJVlQtJ26lBfYIk=; b=3q07sYL0yhADPaWaRsFZbuEACUmvjvsI845fcdVP/YygL23iin5lsXqTat8l6kGnsVpZqi 6FDbUJiwXn/q5Lfzq8hz8wAqG/x1REoNm1JXZaPKaDWj+ONrnWrltRzgkaOFg9+7+1Kfyw 3uF+z/69iDQyRswavU6tSQiz64hPD/OXYOo0LBWbfcMFwJQ81n1pxWlNMdoa6IXwLC/LCp utbjIh5zMZ4eCXz8CWcnbZxyUNDtVv+XV9nExXNtTF9uRIL4aRBN+3qzdbLSo5nbCC7BjI WtonKG0hH/9q38feRmgeXbqtNe1bbb59EBgomCWuE0nFHYmnVJjise7f0I5R6Q== ARC-Authentication-Results: i=1; rspamd-6f5cfd578c-skqph; auth=pass smtp.auth=dreamhost smtp.mailfrom=kjlx@templeofstupid.com X-Sender-Id: dreamhost|x-authsender|kjlx@templeofstupid.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|kjlx@templeofstupid.com X-MailChannels-Auth-Id: dreamhost X-Unite-Attack: 2e72011c0f495acd_1686269356551_455852041 X-MC-Loop-Signature: 1686269356551:2334379012 X-MC-Ingress-Time: 1686269356551 Received: from pdx1-sub0-mail-a313.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.163.30 (trex/6.8.1); Fri, 09 Jun 2023 00:09:16 +0000 Received: from kmjvbox (c-73-93-64-36.hsd1.ca.comcast.net [73.93.64.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kjlx@templeofstupid.com) by pdx1-sub0-mail-a313.dreamhost.com (Postfix) with ESMTPSA id 4QchJq4P4Jz1qB for ; Thu, 8 Jun 2023 17:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=templeofstupid.com; s=dreamhost; t=1686269355; bh=lQJUql2528Cy+DS6D/lrrawtBMQvuJVlQtJ26lBfYIk=; h=Date:From:To:Cc:Subject:Content-Type:Content-Transfer-Encoding; b=dDoHPKhVC+rSbuXrQXH1ctahyAjgA25ZAMjDsDW+522psbJy33cRsO9a2Cg/4XYOi Ltrq5G01Y8FBynl/M4J7Vkd2TZtyVkvfX5p5/NuGhPauvEr5fCwwfu8xzC/sb8vZqG PipsXZb9CtdoVe3oOri82oo52gIu8s+CmmhxOwWw= Received: from johansen (uid 1000) (envelope-from kjlx@templeofstupid.com) id e0042 by kmjvbox (DragonFly Mail Agent v0.12); Thu, 08 Jun 2023 17:09:14 -0700 Date: Thu, 8 Jun 2023 17:09:14 -0700 From: Krister Johansen To: Alexei Starovoitov Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , LKML , "open list:KERNEL SELFTEST FRAMEWORK" , stable Subject: Re: [PATCH bpf v2 2/2] bpf: ensure main program has an extable Message-ID: <20230609000914.GA4980@templeofstupid.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 03:01:36PM -0700, Alexei Starovoitov wrote: > On Wed, Jun 7, 2023 at 2:04 PM Krister Johansen wrote: > > Cc: stable@vger.kernel.org > > Fixes: 1c2a088a6626 ("bpf: x64: add JIT support for multi-function programs") > > Signed-off-by: Krister Johansen > > --- > > kernel/bpf/verifier.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > index 5871aa78d01a..d6939db9fbf9 100644 > > --- a/kernel/bpf/verifier.c > > +++ b/kernel/bpf/verifier.c > > @@ -17242,6 +17242,7 @@ static int jit_subprogs(struct bpf_verifier_env *env) > > prog->jited = 1; > > prog->bpf_func = func[0]->bpf_func; > > prog->jited_len = func[0]->jited_len; > > + prog->aux->extable = func[0]->aux->extable; > > Why not to do this hunk and what I suggested earlier: start from func=1 ? > That will address double ksym insertion that Yonghong mentioned. Sure thing. Yonghong and you have convinced me. I'll send out a v3 with all changes requested so far. -K