From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF76C87FDC for ; Fri, 9 Jun 2023 04:39:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237998AbjFIEjd (ORCPT ); Fri, 9 Jun 2023 00:39:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjFIEj2 (ORCPT ); Fri, 9 Jun 2023 00:39:28 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92B0630EE for ; Thu, 8 Jun 2023 21:39:26 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 759C968C4E; Fri, 9 Jun 2023 06:39:22 +0200 (CEST) Date: Fri, 9 Jun 2023 06:39:22 +0200 From: Christoph Hellwig To: Fabio Estevam Cc: Mark Brown , Christoph Hellwig , axboe@kernel.dk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: fix rootwait= Message-ID: <20230609043922.GA30632@lst.de> References: <20230607135746.92995-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 10:02:00PM -0300, Fabio Estevam wrote: > > below) lands on this commit and reverting the first hunk: > > > > > @@ -181,7 +181,7 @@ static int __init devt_from_devname(const char *name, dev_t *devt) > > > *p = '\0'; > > > *devt = blk_lookup_devt(s, part); > > > if (*devt) > > > - return 0; > > > + return -ENODEV; > > I have tested reverting this first hunk and it also works for me, so > if someone submits this fix: Yes, the first hunk is completely bogus, sorry. I'll send the fix.