From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371E5C7EE25 for ; Fri, 9 Jun 2023 08:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240942AbjFIIgV (ORCPT ); Fri, 9 Jun 2023 04:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240830AbjFIIgA (ORCPT ); Fri, 9 Jun 2023 04:36:00 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3CF930E3; Fri, 9 Jun 2023 01:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686299752; x=1717835752; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SrqOqEQbozaVAjlR+PMI9fwjHqDp6IjKyh5d/Z9Nh0E=; b=NnLniI0tUCGdXwvYMJt0scSkhyTGi4r/EVItaieB8Regf1TmQ/sJ6+hQ sVJjat3b0FZ+U+53sIZ0vn05rbQFBNGZsCo3F0x1ietunaUuSTWSGJRms ntiIDhiwgDt68b/YXTNj1b7i60IqJbG6eGb1c2bKOw3sHRTevlCfs1Ork xzWimhEDMZJA8kJ7qMbA+G6WhYjAmEiEtRYDKH18LsB291SQQRWksMSUQ S+IWq75+80ICsesQxmLWHQeD5KkqLzxKM7aSyArrXLqY2hfK4hFtdJF93 48oxZ7gn+P8b6OSrVF1VMSQRRh559b0bhy9ophaxqolPSwEAxJ8NApg3G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="443918029" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="443918029" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 01:35:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="775415722" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="775415722" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 09 Jun 2023 01:35:45 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 018D534C; Fri, 9 Jun 2023 11:35:52 +0300 (EEST) Date: Fri, 9 Jun 2023 11:35:52 +0300 From: Mika Westerberg To: Raag Jadav Cc: linus.walleij@linaro.org, andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com Subject: Re: [PATCH v2 3/4] pinctrl: intel: simplify exit path of set_mux hook Message-ID: <20230609083552.GM45886@black.fi.intel.com> References: <20230609082539.24311-1-raag.jadav@intel.com> <20230609082539.24311-4-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230609082539.24311-4-raag.jadav@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09, 2023 at 01:55:38PM +0530, Raag Jadav wrote: > Simplify exit path of ->set_mux() hook and save a few bytes. > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-22 (-22) > Function old new delta > intel_pinmux_set_mux 242 220 -22 > Total: Before=10453, After=10431, chg -0.21% > > Signed-off-by: Raag Jadav > --- > drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) This adds one more line so it is not simplifying ;-) I think the original code looks better.