From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Jadav, Raag" <raag.jadav@intel.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>,
"N, Pandith" <pandith.n@intel.com>
Subject: Re: [PATCH v2 3/4] pinctrl: intel: simplify exit path of set_mux hook
Date: Fri, 9 Jun 2023 12:29:20 +0300 [thread overview]
Message-ID: <20230609092920.GQ45886@black.fi.intel.com> (raw)
In-Reply-To: <DM6PR11MB27791AE074AE94F8CA5C02A58C51A@DM6PR11MB2779.namprd11.prod.outlook.com>
On Fri, Jun 09, 2023 at 09:10:42AM +0000, Jadav, Raag wrote:
> > On Fri, Jun 09, 2023 at 01:55:38PM +0530, Raag Jadav wrote:
> > > Simplify exit path of ->set_mux() hook and save a few bytes.
> > >
> > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-22 (-22)
> > > Function old new delta
> > > intel_pinmux_set_mux 242 220 -22
> > > Total: Before=10453, After=10431, chg -0.21%
> > >
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > > drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++----
> > > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > This adds one more line so it is not simplifying ;-)
>
> Would "optimize" sound any better?
No, I think this patch is not useful at all.
next prev parent reply other threads:[~2023-06-09 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:25 [PATCH v2 0/4] Minor improvements for Intel pinctrl Raag Jadav
2023-06-09 8:25 ` [PATCH v2 1/4] pinctrl: intel: refine set_mux hook Raag Jadav
2023-06-09 16:41 ` Andy Shevchenko
2023-06-12 7:15 ` Jadav, Raag
2023-06-12 15:17 ` Andy Shevchenko
2023-06-09 8:25 ` [PATCH v2 2/4] pinctrl: intel: refine irq_set_type hook Raag Jadav
2023-06-09 8:25 ` [PATCH v2 3/4] pinctrl: intel: simplify exit path of set_mux hook Raag Jadav
2023-06-09 8:35 ` Mika Westerberg
2023-06-09 9:10 ` Jadav, Raag
2023-06-09 9:29 ` Mika Westerberg [this message]
2023-06-09 8:25 ` [PATCH v2 4/4] pinctrl: intel: simplify exit path of gpio_request_enable hook Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609092920.GQ45886@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=pandith.n@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox