[PATCH] accel/habanalabs: add more debugfs stub helpers

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] accel/habanalabs: add more debugfs stub helpers
@ 2023-06-09 12:06 Arnd Bergmann
  2023-06-09 13:37 ` Tomer Tayar
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2023-06-09 12:06 UTC (permalink / raw)
  To: Oded Gabbay, Tomer Tayar
  Cc: Arnd Bergmann, Ofir Bitton, Ohad Sharabi, Dafna Hirschfeld,
	dri-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Two functions got added with normal prototypes for debugfs, but not
alternative when building without it:

drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]

Add stubs for these as well.

Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
index d92ba2e30e310..2f027d5a82064 100644
--- a/drivers/accel/habanalabs/common/habanalabs.h
+++ b/drivers/accel/habanalabs/common/habanalabs.h
@@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
 {
 }

+static inline int hl_debugfs_device_init(struct hl_device *hdev)
+{
+	return 0;
+}
+
+static inline void hl_debugfs_device_fini(struct hl_device *hdev)
+{
+}
+
 static inline void hl_debugfs_add_device(struct hl_device *hdev)
 {
 }
-- 
2.39.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] accel/habanalabs: add more debugfs stub helpers
  2023-06-09 12:06 [PATCH] accel/habanalabs: add more debugfs stub helpers Arnd Bergmann
@ 2023-06-09 13:37 ` Tomer Tayar
  2023-06-11  9:50   ` Oded Gabbay
  0 siblings, 1 reply; 5+ messages in thread
From: Tomer Tayar @ 2023-06-09 13:37 UTC (permalink / raw)
  To: Arnd Bergmann, Oded Gabbay
  Cc: Arnd Bergmann, Ofir Bitton, Ohad Sharabi, Dafna Hirschfeld,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org

On 09/06/2023 15:06, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Two functions got added with normal prototypes for debugfs, but not
> alternative when building without it:
>
> drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
>
> Add stubs for these as well.
>
> Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks,
Reviewed-by: Tomer Tayar <ttayar@habana.ai>

> ---
>   drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> index d92ba2e30e310..2f027d5a82064 100644
> --- a/drivers/accel/habanalabs/common/habanalabs.h
> +++ b/drivers/accel/habanalabs/common/habanalabs.h
> @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
>   {
>   }
>   
> +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> +{
> +	return 0;
> +}
> +
> +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> +{
> +}
> +
>   static inline void hl_debugfs_add_device(struct hl_device *hdev)
>   {
>   }



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] accel/habanalabs: add more debugfs stub helpers
  2023-06-09 13:37 ` Tomer Tayar
@ 2023-06-11  9:50   ` Oded Gabbay
  2023-07-20 10:29     ` Daniel Vetter
  0 siblings, 1 reply; 5+ messages in thread
From: Oded Gabbay @ 2023-06-11  9:50 UTC (permalink / raw)
  To: Tomer Tayar
  Cc: Arnd Bergmann, Arnd Bergmann, Ofir Bitton, Ohad Sharabi,
	Dafna Hirschfeld, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org

On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar <ttayar@habana.ai> wrote:
>
> On 09/06/2023 15:06, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Two functions got added with normal prototypes for debugfs, but not
> > alternative when building without it:
> >
> > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
> >
> > Add stubs for these as well.
> >
> > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks,
> Reviewed-by: Tomer Tayar <ttayar@habana.ai>

Thanks,
Applied to -fixes.
Oded
>
> > ---
> >   drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> > index d92ba2e30e310..2f027d5a82064 100644
> > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> >   {
> >   }
> >
> > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > +{
> > +     return 0;
> > +}
> > +
> > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > +{
> > +}
> > +
> >   static inline void hl_debugfs_add_device(struct hl_device *hdev)
> >   {
> >   }
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] accel/habanalabs: add more debugfs stub helpers
  2023-06-11  9:50   ` Oded Gabbay
@ 2023-07-20 10:29     ` Daniel Vetter
  2023-07-20 10:36       ` Oded Gabbay
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2023-07-20 10:29 UTC (permalink / raw)
  To: Oded Gabbay
  Cc: Tomer Tayar, Arnd Bergmann, Ohad Sharabi, Arnd Bergmann,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Dafna Hirschfeld, Ofir Bitton

On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote:
> On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar <ttayar@habana.ai> wrote:
> >
> > On 09/06/2023 15:06, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > Two functions got added with normal prototypes for debugfs, but not
> > > alternative when building without it:
> > >
> > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> > > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
> > >
> > > Add stubs for these as well.
> > >
> > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Thanks,
> > Reviewed-by: Tomer Tayar <ttayar@habana.ai>
> 
> Thanks,
> Applied to -fixes.

As requested applied to drm-fixes, hopeful for the next one your drm-misc
account issue is fixed.
-Daniel

> Oded
> >
> > > ---
> > >   drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> > >   1 file changed, 9 insertions(+)
> > >
> > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> > > index d92ba2e30e310..2f027d5a82064 100644
> > > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> > >   {
> > >   }
> > >
> > > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > > +{
> > > +     return 0;
> > > +}
> > > +
> > > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > > +{
> > > +}
> > > +
> > >   static inline void hl_debugfs_add_device(struct hl_device *hdev)
> > >   {
> > >   }
> >
> >

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] accel/habanalabs: add more debugfs stub helpers
  2023-07-20 10:29     ` Daniel Vetter
@ 2023-07-20 10:36       ` Oded Gabbay
  0 siblings, 0 replies; 5+ messages in thread
From: Oded Gabbay @ 2023-07-20 10:36 UTC (permalink / raw)
  To: Oded Gabbay, Tomer Tayar, Arnd Bergmann, Ohad Sharabi,
	Arnd Bergmann, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Dafna Hirschfeld, Ofir Bitton

On Thu, Jul 20, 2023 at 1:29 PM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote:
> > On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar <ttayar@habana.ai> wrote:
> > >
> > > On 09/06/2023 15:06, Arnd Bergmann wrote:
> > > > From: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > Two functions got added with normal prototypes for debugfs, but not
> > > > alternative when building without it:
> > > >
> > > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > > > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> > > > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
> > > >
> > > > Add stubs for these as well.
> > > >
> > > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >
> > > Thanks,
> > > Reviewed-by: Tomer Tayar <ttayar@habana.ai>
> >
> > Thanks,
> > Applied to -fixes.
>
> As requested applied to drm-fixes, hopeful for the next one your drm-misc
> account issue is fixed.
> -Daniel

Thanks Daniel for the help.
I also hope it will be fixed :)
Oded

>
> > Oded
> > >
> > > > ---
> > > >   drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> > > >   1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> > > > index d92ba2e30e310..2f027d5a82064 100644
> > > > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > > > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > > > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> > > >   {
> > > >   }
> > > >
> > > > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > > > +{
> > > > +     return 0;
> > > > +}
> > > > +
> > > > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > > > +{
> > > > +}
> > > > +
> > > >   static inline void hl_debugfs_add_device(struct hl_device *hdev)
> > > >   {
> > > >   }
> > >
> > >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-07-20 10:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-09 12:06 [PATCH] accel/habanalabs: add more debugfs stub helpers Arnd Bergmann
2023-06-09 13:37 ` Tomer Tayar
2023-06-11  9:50   ` Oded Gabbay
2023-07-20 10:29     ` Daniel Vetter
2023-07-20 10:36       ` Oded Gabbay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox