From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F31C7EE25 for ; Fri, 9 Jun 2023 22:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbjFIWf1 (ORCPT ); Fri, 9 Jun 2023 18:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231859AbjFIWfW (ORCPT ); Fri, 9 Jun 2023 18:35:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 372253A84 for ; Fri, 9 Jun 2023 15:35:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C196564B2F for ; Fri, 9 Jun 2023 22:35:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD149C433EF; Fri, 9 Jun 2023 22:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686350120; bh=PR8FdNBLbJbGY5zpNMCVwfa2i1gZj6GmFa28PRONZTU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U+P+vCdh0Ba29HNhX2kUpOR587ERtLFyeySYkbqfbAgzW41EMpXQop9moYy2oeby+ mf8GkhQpxACc6+fUFv+SCdLISw4IxKzqV6TwoLSyiMQOiisQ3Ix5k7C8IPDjDeCobP AeGOeqV0ZqdyKEELEziul1q0sOlv9fLBFukOeUTI= Date: Fri, 9 Jun 2023 15:35:19 -0700 From: Andrew Morton To: "zhaoyang.huang" Cc: Matthew Wilcox , Suren Baghdasaryan , Minchan Kim , , , Zhaoyang Huang , Subject: Re: [PATCHv5] mm: skip CMA pages when they are not available Message-Id: <20230609153519.ff01046ef0faff00a74bd5b0@linux-foundation.org> In-Reply-To: <1685501461-19290-1-git-send-email-zhaoyang.huang@unisoc.com> References: <1685501461-19290-1-git-send-email-zhaoyang.huang@unisoc.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2023 10:51:01 +0800 "zhaoyang.huang" wrote: > From: Zhaoyang Huang > > This patch fixes unproductive reclaiming of CMA pages by skipping them when they > are not available for current context. It is arise from bellowing OOM issue, which > caused by large proportion of MIGRATE_CMA pages among free pages. > > [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allocation failure: order:0, mode:0xc00(GFP_NOIO), nodemask=(null),cpuset=foreground,mems_allowed=0 > [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 217*16kB (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C) 0*1024kB 0*2048kB 0*4096kB = 35848kB > [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*8kB (MEH) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H) 0*1024kB 0*2048kB 0*4096kB = 3236kB > ... > [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate memory on node -1, gfp=0xa20(GFP_ATOMIC) > [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object size: 64, buffer size: 64, default order: 0, min order: 0 > [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 3392, free: 0 > We saw plenty of feedback for earlier versions, but now silence. Does this mean we're all OK with v5?