public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li zeming <zeming@nfschina.com>
To: jstultz@google.com, tglx@linutronix.de, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com>
Subject: [PATCH] time: alarmtimer: Optimization function return value
Date: Sat, 10 Jun 2023 02:09:55 +0800	[thread overview]
Message-ID: <20230609180955.4357-1-zeming@nfschina.com> (raw)

Replace -1 return values with -EPERM.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 kernel/time/alarmtimer.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index 82b28ab0f328..e918d556dd51 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -92,9 +92,9 @@ static int alarmtimer_rtc_add_device(struct device *dev)
 		return -EBUSY;
 
 	if (!test_bit(RTC_FEATURE_ALARM, rtc->features))
-		return -1;
+		return -EPERM;
 	if (!device_may_wakeup(rtc->dev.parent))
-		return -1;
+		return -EPERM;
 
 	pdev = platform_device_register_data(dev, "alarmtimer",
 					     PLATFORM_DEVID_AUTO, NULL, 0);
@@ -104,7 +104,7 @@ static int alarmtimer_rtc_add_device(struct device *dev)
 	spin_lock_irqsave(&rtcdev_lock, flags);
 	if (!IS_ERR(pdev) && !rtcdev) {
 		if (!try_module_get(rtc->owner)) {
-			ret = -1;
+			ret = -EPERM;
 			goto unlock;
 		}
 
@@ -113,7 +113,7 @@ static int alarmtimer_rtc_add_device(struct device *dev)
 		get_device(dev);
 		pdev = NULL;
 	} else {
-		ret = -1;
+		ret = -EPERM;
 	}
 unlock:
 	spin_unlock_irqrestore(&rtcdev_lock, flags);
-- 
2.18.2


             reply	other threads:[~2023-06-08  1:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 18:09 Li zeming [this message]
2023-06-10 12:20 ` [PATCH] time: alarmtimer: Optimization function return value Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609180955.4357-1-zeming@nfschina.com \
    --to=zeming@nfschina.com \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox