From: Christoph Hellwig <hch@lst.de>
To: Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, tianjia.zhang@linux.alibaba.com,
xiang@kernel.org, casey@schaufler-ca.com
Subject: Re: [RFC] block: relax permission for Persistent Reservations ioctl
Date: Sat, 10 Jun 2023 08:06:26 +0200 [thread overview]
Message-ID: <20230610060626.GA1595@lst.de> (raw)
In-Reply-To: <20230609102122.118800-1-jefflexu@linux.alibaba.com>
On Fri, Jun 09, 2023 at 06:21:22PM +0800, Jingbo Xu wrote:
> When the shared storage is accessed from containers [1], it's not
> recommended to grant CAP_SYS_ADMIN to containers for access to
> Persistent Reservations in risk of container escape.
>
> Remove the extra CAP_SYS_ADMIN permission constraint for Persistent
> Reservations ioctl which shall do no harm [2].
I think we still to check that if CAP_SYS_ADMIN is not present,
the file descriptors needs to be open for write, and we're not called
on a partition (the latter should probbaly be always checked,
as a reservation for a partitions doesn't make sense).
But in general I think relaxing this is a good idea, we just need to
be very careful. Looking at the discussion of unprivileged nvme
command passthrough might be a good start.
next prev parent reply other threads:[~2023-06-10 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 10:21 [RFC] block: relax permission for Persistent Reservations ioctl Jingbo Xu
2023-06-10 6:06 ` Christoph Hellwig [this message]
2023-06-10 8:12 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610060626.GA1595@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=casey@schaufler-ca.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox