From: Tom Rix <trix@redhat.com>
To: yazen.ghannam@amd.com, bp@alien8.de, tony.luck@intel.com,
james.morse@arm.com, mchehab@kernel.org, rric@kernel.org
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static
Date: Sat, 10 Jun 2023 17:09:30 -0400 [thread overview]
Message-ID: <20230610210930.174074-1-trix@redhat.com> (raw)
smatch reports
drivers/edac/amd64_edac.c:990:3: warning: symbol
'gpu_node_map' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/edac/amd64_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 5d7c080d96a2..597dae7692b1 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -984,7 +984,7 @@ static int sys_addr_to_csrow(struct mem_ctl_info *mci, u64 sys_addr)
* system and what the lowest AMD Node ID value is for the GPU nodes. Use this
* info to fixup the Linux logical "Node ID" value set in the AMD NB code and EDAC.
*/
-struct local_node_map {
+static struct local_node_map {
u16 node_count;
u16 base_node_id;
} gpu_node_map;
--
2.27.0
next reply other threads:[~2023-06-10 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 21:09 Tom Rix [this message]
2023-06-14 15:21 ` [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static Yazen Ghannam
2023-06-19 11:07 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610210930.174074-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox