From: Yongsheng Yang <iyysheng@gmail.com>
To: linux@roeck-us.net
Cc: corbet@lwn.net, iyysheng@gmail.com, jdelvare@suse.com,
linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation/hwmon: Fix description of devm_hwmon_device_unregister()
Date: Mon, 12 Jun 2023 05:42:46 +0400 [thread overview]
Message-ID: <20230612014246.1394-1-iyysheng@gmail.com> (raw)
In-Reply-To: <e605a8d8-4f40-447d-8238-eccb7e22342a@roeck-us.net>
> On Fri, Jun 09, 2023 at 11:55:10AM +0400, Yongsheng Yang wrote:
> > Use devm_hwmon_device_register_with_info to replace
> > hwmon_device_register_with_info in description of
> > devm_hwmon_device_unregister.
> >
>
> You didn't add () to function names, but I guess it is better to do that
> in a separate patch anyway.
>
> Applied.
>
> Thanks,
> Guenter
>
Ok, I just add () to function names in commit message title. I will add
() to function names releate in the whole commit message. Then I will
post the updated version.
Thanks
Yongsheng
> > Signed-off-by: Yongsheng Yang <iyysheng@gmail.com>
> > Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> > ---
> > Documentation/hwmon/hwmon-kernel-api.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/hwmon/hwmon-kernel-api.rst b/Documentation/hwmon/hwmon-kernel-api.rst
> > index c2d1e0299d8d..6cacf7daf25c 100644
> > --- a/Documentation/hwmon/hwmon-kernel-api.rst
> > +++ b/Documentation/hwmon/hwmon-kernel-api.rst
> > @@ -66,7 +66,7 @@ hwmon_device_register_with_info.
> >
> > devm_hwmon_device_unregister does not normally have to be called. It is only
> > needed for error handling, and only needed if the driver probe fails after
> > -the call to hwmon_device_register_with_info and if the automatic (device
> > +the call to devm_hwmon_device_register_with_info and if the automatic (device
> > managed) removal would be too late.
> >
> > All supported hwmon device registration functions only accept valid device
prev parent reply other threads:[~2023-06-12 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 7:55 [PATCH v2] Documentation/hwmon: Fix description of devm_hwmon_device_unregister() Yongsheng Yang
2023-06-09 13:44 ` Bagas Sanjaya
2023-06-10 14:39 ` Guenter Roeck
2023-06-12 1:42 ` Yongsheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612014246.1394-1-iyysheng@gmail.com \
--to=iyysheng@gmail.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox