Re: [PATCH 20/26] dt-bindings: net: qcom,ethqos: add description for sa8775p

Krzysztof Kozlowski
2023-06-14T07:27:23Z

On 12/06/2023 11:23, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add the compatible for the MAC controller on sa8775p platforms. This MAC
> works with a single interrupt so add minItems to the interrupts property.
> The fourth clock's name is different here so change it. Enable relevant
> PHY properties.
>

I think the patch should be squashed with previous. Adding compatible to
common snps,dwmac binding does not make sense on its own. It makes sense
with adding compatible here.

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> .../devicetree/bindings/net/qcom,ethqos.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 60a38044fb19..b20847c275ce 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -20,6 +20,7 @@ properties:
> compatible:
> enum:
> - qcom,qcs404-ethqos
> + - qcom,sa8775p-ethqos
> - qcom,sc8280xp-ethqos
> - qcom,sm8150-ethqos
>
> @@ -32,11 +33,13 @@ properties:
> - const: rgmii
>
> interrupts:
> + minItems: 1
> items:
> - description: Combined signal for various interrupt events
> - description: The interrupt that occurs when Rx exits the LPI state
>
> interrupt-names:
> + minItems: 1
> items:
> - const: macirq
> - const: eth_lpi
> @@ -49,11 +52,20 @@ properties:
> - const: stmmaceth
> - const: pclk
> - const: ptp_ref
> - - const: rgmii
> + - enum:
> + - rgmii
> + - phyaux
>
> iommus:
> maxItems: 1
>
> + phys: true
> +
> + phy-supply: true

Isn't this property of the phy?

> +
> + phy-names:
> + const: serdes

Keep the phy-names after phys.

Best regards,
Krzysztof