From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ricardo Neri <ricardo.neri@intel.com>,
"Ravi V . Shankar" <ravi.v.shankar@intel.com>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Len Brown <len.brown@intel.com>, Mel Gorman <mgorman@suse.de>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Valentin Schneider <vschneid@redhat.com>,
Ionela Voinescu <ionela.voinescu@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Shrikanth Hegde <sshegde@linux.vnet.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
naveen.n.rao@linux.vnet.ibm.com,
Yicong Yang <yangyicong@hisilicon.com>,
Barry Song <v-songbaohua@oppo.com>, Chen Yu <yu.c.chen@intel.com>,
Hillf Danton <hdanton@sina.com>
Subject: Re: [Patch v2 1/6] sched/fair: Determine active load balance for SMT sched groups
Date: Mon, 12 Jun 2023 13:16:02 +0200 [thread overview]
Message-ID: <20230612111602.GJ4253@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <253f5272200d3cec3f24427262bb4e95244f681c.1686263351.git.tim.c.chen@linux.intel.com>
On Thu, Jun 08, 2023 at 03:32:27PM -0700, Tim Chen wrote:
> @@ -10371,6 +10436,11 @@ static struct sched_group *find_busiest_group(struct lb_env *env)
> */
> goto out_balanced;
>
> + if (busiest->group_type == group_smt_balance &&
> + smt_vs_nonsmt_groups(sds.local, sds.busiest))
> + /* Let non SMT CPU pull from SMT CPU sharing with sibling */
> + goto force_balance;
> +
> if (busiest->group_weight > 1 &&
> local->idle_cpus <= (busiest->idle_cpus + 1))
> /*
Could you please add {} for all of them? The comment makes them all
multi-line.
next prev parent reply other threads:[~2023-06-12 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 22:32 [Patch v2 0/6] Enable Cluster Scheduling for x86 Hybrid CPUs Tim Chen
2023-06-08 22:32 ` [Patch v2 1/6] sched/fair: Determine active load balance for SMT sched groups Tim Chen
2023-06-12 11:13 ` Peter Zijlstra
2023-06-12 20:12 ` Tim Chen
2023-06-12 20:14 ` Peter Zijlstra
2023-06-12 11:16 ` Peter Zijlstra [this message]
2023-06-12 20:12 ` Tim Chen
2023-06-08 22:32 ` [Patch v2 2/6] sched/topology: Record number of cores in sched group Tim Chen
2023-06-12 11:29 ` Peter Zijlstra
2023-06-12 20:16 ` Tim Chen
2023-06-08 22:32 ` [Patch v2 3/6] sched/fair: Implement prefer sibling imbalance calculation between asymmetric groups Tim Chen
2023-06-12 12:05 ` Peter Zijlstra
2023-06-13 17:46 ` Tim Chen
2023-06-15 11:07 ` Peter Zijlstra
2023-06-15 17:01 ` Tim Chen
2023-06-08 22:32 ` [Patch v2 4/6] sched/fair: Consider the idle state of the whole core for load balance Tim Chen
2023-06-08 22:32 ` [Patch v2 5/6] sched/x86: Add cluster topology to hybrid CPU Tim Chen
2023-06-08 22:32 ` [Patch v2 6/6] sched/debug: Dump domains' sched group flags Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612111602.GJ4253@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hdanton@sina.com \
--cc=ionela.voinescu@arm.com \
--cc=juri.lelli@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sshegde@linux.vnet.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=v-songbaohua@oppo.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=x86@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox