From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: <andy.shevchenko@gmail.com>
Cc: Markus Burri <markus.burri@mt.com>,
<linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v1] iio: adc: ad7192: store indio_dev into spi driver data
Date: Mon, 12 Jun 2023 12:45:48 +0100 [thread overview]
Message-ID: <20230612124548.00007778@Huawei.com> (raw)
In-Reply-To: <ZIbwUKxlhWQZYnPz@surfacebook>
On Mon, 12 Jun 2023 13:15:44 +0300
<andy.shevchenko@gmail.com> wrote:
> Mon, Jun 12, 2023 at 10:08:47AM +0200, Markus Burri kirjoitti:
> > After calibration the indio_dev is used to get channel information.
> > Since the pointer is not stored into spi driver data, there is a kernel
> > null pointer dereference.
> > Store the indio_dev into spi driver data to fix this.
>
> This definitely deserves the Fixes tag. Can you dig the history to find the
> culprit one?
Good catch, but see
https://lore.kernel.org/all/20230530075311.400686-2-fl.scratchpad@gmail.com/
Which I think is a nicer fix for the same issue.
I sent a pull request for that fix yesterday, but given we are late in the cycle
it might go in during the merge window then get backported to stable kernels
after that.
>
> > Add error check and slightly extend the debug messages.
>
> I'm not sure this will belong to the same change, so I would split this out to
> a separate one.
Definitely. Multiple issues so multiple patches.
Thanks,
Jonathan
>
prev parent reply other threads:[~2023-06-12 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 8:08 [PATCH v1] iio: adc: ad7192: store indio_dev into spi driver data Markus Burri
2023-06-12 10:15 ` andy.shevchenko
2023-06-12 11:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612124548.00007778@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.burri@mt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox