Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions

Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions

[Greg Kroah-Hartman]

On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> Export the tracing function "sched_process_fork" and
> "sched_process_exit" for process statistics.
> 
> Change-Id: I67dcdcb26371cd7a495ff0b210361742b1a2088e
> Signed-off-by: jim.tsai <Wei-chin.Tsai@mediatek.com>

You might want to run scripts/checkpatch.pl on your patch before you
send it out again, you don't need a change-id line.

Also, here's what my bot says:

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch contains warnings and/or errors noticed by the
  scripts/checkpatch.pl tool.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions

[Greg Kroah-Hartman]

On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> --- /dev/null
> +++ b/drivers/misc/mediatek_mbraink/mbraink_data.c
> @@ -0,0 +1,417 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2022 MediaTek Inc.

It's 2023 :)

Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions

[Greg Kroah-Hartman]

On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> +static void class_create_release(struct class *cls)
> +{
> +	/*do nothing because the mbraink class is not from malloc*/
> +}

Then the code is totally broken and wrong :(

Please just use the misc device api instead, it is much simpler and
doesn't have these types of errors.

thanks,

greg k-h

Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions

[Wei-chin Tsai (蔡維晉)]

On Mon, 2023-06-12 at 18:37 +0200, Greg Kroah-Hartman wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> > +static void class_create_release(struct class *cls)
> > +{
> > +/*do nothing because the mbraink class is not from malloc*/
> > +}
> 
> Then the code is totally broken and wrong :(
> 
> Please just use the misc device api instead, it is much simpler and
> doesn't have these types of errors.
> 
> thanks,
> 
> greg k-h


Sorry, I did not really get the point from above comments because It
works well for me for the mbraink_main.c and no compiler errors or
runtime errors?

thanks.

Jim

Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions

[gregkh]

On Tue, Jun 13, 2023 at 09:12:38AM +0000, Wei-chin Tsai (蔡維晉) wrote:
> On Mon, 2023-06-12 at 18:37 +0200, Greg Kroah-Hartman wrote:
> >  	 
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> > > +static void class_create_release(struct class *cls)
> > > +{
> > > +/*do nothing because the mbraink class is not from malloc*/
> > > +}
> > 
> > Then the code is totally broken and wrong :(
> > 
> > Please just use the misc device api instead, it is much simpler and
> > doesn't have these types of errors.
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> Sorry, I did not really get the point from above comments because It
> works well for me for the mbraink_main.c and no compiler errors or
> runtime errors?

Think about why the kernel is trying to check if you have a release
function or not.  Would an "empty" function be the same thing?

That check was added to tell you that your design is wrong and needs to
be fixed, do NOT just try to paper over warnings from the kernel as
someone spent the time to try to be nice and tell you that the code is
incorrect :)

Anyway, almost all of these (if not all), can just go away if you move
to  use the miscdevice api instead.

Also, please don't send HTML email, the mailing lists reject it :(

thanks,

greg k-h