public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: David Gow <davidgow@google.com>
Cc: SeongJae Park <sj@kernel.org>,
	brendanhiggins@google.com, linux-kselftest@vger.kernel.org,
	kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: Add source tree entry for kunit
Date: Tue, 13 Jun 2023 00:01:30 +0000	[thread overview]
Message-ID: <20230613000130.85038-1-sj@kernel.org> (raw)
In-Reply-To: <CABVgOS=HpS9g+YwLth2xpY9i2u3DxLzbbPoqnJshhAhU2fB_pA@mail.gmail.com>

On Tue, 13 Jun 2023 07:54:01 +0800 David Gow <davidgow@google.com> wrote:

> [-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
> 
> On Sun, 11 Jun 2023 at 02:05, SeongJae Park <sj@kernel.org> wrote:
> >
> > Patches for kunit are managed in linux-kselftest tree before merged into
> > the mainline, but the MAINTAINERS section for kunit doesn't have the
> > entry for the tree.  Add it.
> >
> > Signed-off-by: SeongJae Park <sj@kernel.org>
> > ---
> 
> Thanks very much.

My pleasure! :)

> 
> Given KUnit work happens in the kunit and kunit-fixes branches here,
> should we note those as well?

That makes sense, I will add those in the commit message with the next version
of this.

> 
> -- David
> 
> 
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ce5f343c1443..8a217438956b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11327,6 +11327,7 @@ L:      linux-kselftest@vger.kernel.org
> >  L:     kunit-dev@googlegroups.com
> >  S:     Maintained
> >  W:     https://google.github.io/kunit-docs/third_party/kernel/docs/
> > +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> 
> Should we also mention the branch here:
> git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> kunit

I think so.  Would you prefer having only one 'T' line with 'kunit' branch?
Or, both branches like below?  I have no strong opinion.

T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit
T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes


Thanks,
SJ

> 
> >  F:     Documentation/dev-tools/kunit/
> >  F:     include/kunit/
> >  F:     lib/kunit/
> > --
> > 2.25.1
> >
> 

  reply	other threads:[~2023-06-13  0:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-10 18:05 [PATCH] MAINTAINERS: Add source tree entry for kunit SeongJae Park
2023-06-12 23:54 ` David Gow
2023-06-13  0:01   ` SeongJae Park [this message]
2023-06-13  0:45     ` David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230613000130.85038-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox