* [PATCH] MAINTAINERS: Add source tree entry for kunit
@ 2023-06-10 18:05 SeongJae Park
2023-06-12 23:54 ` David Gow
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2023-06-10 18:05 UTC (permalink / raw)
To: brendanhiggins, davidgow
Cc: linux-kselftest, kunit-dev, linux-kernel, SeongJae Park
Patches for kunit are managed in linux-kselftest tree before merged into
the mainline, but the MAINTAINERS section for kunit doesn't have the
entry for the tree. Add it.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index ce5f343c1443..8a217438956b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11327,6 +11327,7 @@ L: linux-kselftest@vger.kernel.org
L: kunit-dev@googlegroups.com
S: Maintained
W: https://google.github.io/kunit-docs/third_party/kernel/docs/
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
F: Documentation/dev-tools/kunit/
F: include/kunit/
F: lib/kunit/
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MAINTAINERS: Add source tree entry for kunit
2023-06-10 18:05 [PATCH] MAINTAINERS: Add source tree entry for kunit SeongJae Park
@ 2023-06-12 23:54 ` David Gow
2023-06-13 0:01 ` SeongJae Park
0 siblings, 1 reply; 4+ messages in thread
From: David Gow @ 2023-06-12 23:54 UTC (permalink / raw)
To: SeongJae Park; +Cc: brendanhiggins, linux-kselftest, kunit-dev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
On Sun, 11 Jun 2023 at 02:05, SeongJae Park <sj@kernel.org> wrote:
>
> Patches for kunit are managed in linux-kselftest tree before merged into
> the mainline, but the MAINTAINERS section for kunit doesn't have the
> entry for the tree. Add it.
>
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
Thanks very much.
Given KUnit work happens in the kunit and kunit-fixes branches here,
should we note those as well?
-- David
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ce5f343c1443..8a217438956b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11327,6 +11327,7 @@ L: linux-kselftest@vger.kernel.org
> L: kunit-dev@googlegroups.com
> S: Maintained
> W: https://google.github.io/kunit-docs/third_party/kernel/docs/
> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
Should we also mention the branch here:
git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
kunit
> F: Documentation/dev-tools/kunit/
> F: include/kunit/
> F: lib/kunit/
> --
> 2.25.1
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MAINTAINERS: Add source tree entry for kunit
2023-06-12 23:54 ` David Gow
@ 2023-06-13 0:01 ` SeongJae Park
2023-06-13 0:45 ` David Gow
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2023-06-13 0:01 UTC (permalink / raw)
To: David Gow
Cc: SeongJae Park, brendanhiggins, linux-kselftest, kunit-dev,
linux-kernel
On Tue, 13 Jun 2023 07:54:01 +0800 David Gow <davidgow@google.com> wrote:
> [-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
>
> On Sun, 11 Jun 2023 at 02:05, SeongJae Park <sj@kernel.org> wrote:
> >
> > Patches for kunit are managed in linux-kselftest tree before merged into
> > the mainline, but the MAINTAINERS section for kunit doesn't have the
> > entry for the tree. Add it.
> >
> > Signed-off-by: SeongJae Park <sj@kernel.org>
> > ---
>
> Thanks very much.
My pleasure! :)
>
> Given KUnit work happens in the kunit and kunit-fixes branches here,
> should we note those as well?
That makes sense, I will add those in the commit message with the next version
of this.
>
> -- David
>
>
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ce5f343c1443..8a217438956b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11327,6 +11327,7 @@ L: linux-kselftest@vger.kernel.org
> > L: kunit-dev@googlegroups.com
> > S: Maintained
> > W: https://google.github.io/kunit-docs/third_party/kernel/docs/
> > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
>
> Should we also mention the branch here:
> git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> kunit
I think so. Would you prefer having only one 'T' line with 'kunit' branch?
Or, both branches like below? I have no strong opinion.
T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit
T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes
Thanks,
SJ
>
> > F: Documentation/dev-tools/kunit/
> > F: include/kunit/
> > F: lib/kunit/
> > --
> > 2.25.1
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MAINTAINERS: Add source tree entry for kunit
2023-06-13 0:01 ` SeongJae Park
@ 2023-06-13 0:45 ` David Gow
0 siblings, 0 replies; 4+ messages in thread
From: David Gow @ 2023-06-13 0:45 UTC (permalink / raw)
To: SeongJae Park; +Cc: brendanhiggins, linux-kselftest, kunit-dev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]
On Tue, 13 Jun 2023 at 08:01, SeongJae Park <sj@kernel.org> wrote:
>
> On Tue, 13 Jun 2023 07:54:01 +0800 David Gow <davidgow@google.com> wrote:
>
> > [-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
> >
> > On Sun, 11 Jun 2023 at 02:05, SeongJae Park <sj@kernel.org> wrote:
> > >
> > > Patches for kunit are managed in linux-kselftest tree before merged into
> > > the mainline, but the MAINTAINERS section for kunit doesn't have the
> > > entry for the tree. Add it.
> > >
> > > Signed-off-by: SeongJae Park <sj@kernel.org>
> > > ---
> >
> > Thanks very much.
>
> My pleasure! :)
>
> >
> > Given KUnit work happens in the kunit and kunit-fixes branches here,
> > should we note those as well?
>
> That makes sense, I will add those in the commit message with the next version
> of this.
>
> >
> > -- David
> >
> >
> > > MAINTAINERS | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ce5f343c1443..8a217438956b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11327,6 +11327,7 @@ L: linux-kselftest@vger.kernel.org
> > > L: kunit-dev@googlegroups.com
> > > S: Maintained
> > > W: https://google.github.io/kunit-docs/third_party/kernel/docs/
> > > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> >
> > Should we also mention the branch here:
> > git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> > kunit
>
> I think so. Would you prefer having only one 'T' line with 'kunit' branch?
> Or, both branches like below? I have no strong opinion.
>
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes
>
>
Let's go with both, assuming no-one else objects.
Cheers,
-- David
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-13 0:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-10 18:05 [PATCH] MAINTAINERS: Add source tree entry for kunit SeongJae Park
2023-06-12 23:54 ` David Gow
2023-06-13 0:01 ` SeongJae Park
2023-06-13 0:45 ` David Gow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox