From: Kees Cook <keescook@chromium.org>
To: Rae Moar <rmoar@google.com>
Cc: shuah@kernel.org, davidgow@google.com, dlatypov@google.com,
brendan.higgins@linux.dev, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, jstultz@google.com,
tglx@linutronix.de, sboyd@kernel.org
Subject: Re: [RFC v1 3/6] kunit: Add ability to filter attributes
Date: Tue, 13 Jun 2023 13:26:53 -0700 [thread overview]
Message-ID: <202306131324.5B69ABC@keescook> (raw)
In-Reply-To: <20230610005149.1145665-4-rmoar@google.com>
On Sat, Jun 10, 2023 at 12:51:46AM +0000, Rae Moar wrote:
> Add filtering of test attributes. Users can filter tests using a
> module_param_array called "filter". This functionality will be added to
> kunit.py in the next patch.
>
> The filters will be imputed in the format:
> "<attribute_name><operation><attribute_value>"
>
> Example: "speed>slow"
>
> Operations include: >, <, >=, <=, !=, and =. These operations do not need
> to act the same for every attribute.
How is the "default" filter specified? Is explicitly unfiltered? (i.e.
"slow" stuff will run by default?) Or should there be a default filter
of "speed<slow" for the memcpy conversion?
But yes, I'm a fan of this whole series! I would much prefer this to
having one-off CONFIGs for slow tests. :)
--
Kees Cook
next prev parent reply other threads:[~2023-06-13 20:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 0:51 [RFC v1 0/6] kunit: Add test attributes API Rae Moar
2023-06-10 0:51 ` [RFC v1 1/6] kunit: Add test attributes API structure Rae Moar
2023-06-10 8:29 ` David Gow
2023-06-13 20:36 ` Rae Moar
2023-06-10 0:51 ` [RFC v1 2/6] kunit: Add speed attribute Rae Moar
2023-06-10 8:29 ` David Gow
2023-06-13 20:37 ` Rae Moar
2023-06-10 0:51 ` [RFC v1 3/6] kunit: Add ability to filter attributes Rae Moar
2023-06-10 8:29 ` David Gow
2023-06-13 20:42 ` Rae Moar
2023-06-13 20:26 ` Kees Cook [this message]
2023-06-13 20:58 ` Rae Moar
2023-06-10 0:51 ` [RFC v1 4/6] kunit: tool: Add command line interface to filter and report attributes Rae Moar
2023-06-10 8:29 ` David Gow
2023-06-13 20:44 ` Rae Moar
2023-06-10 0:51 ` [RFC v1 5/6] kunit: memcpy: Mark tests as slow using test attributes Rae Moar
2023-06-10 8:29 ` David Gow
2023-06-13 20:44 ` Rae Moar
2023-06-10 0:51 ` [RFC v1 6/6] kunit: time: Mark test " Rae Moar
2023-06-10 8:29 ` [RFC v1 0/6] kunit: Add test attributes API David Gow
2023-06-13 20:34 ` Rae Moar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306131324.5B69ABC@keescook \
--to=keescook@chromium.org \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=jstultz@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox