From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D28EB64D8 for ; Tue, 13 Jun 2023 19:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240025AbjFMTEG (ORCPT ); Tue, 13 Jun 2023 15:04:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjFMTED (ORCPT ); Tue, 13 Jun 2023 15:04:03 -0400 Received: from smtp-fw-52002.amazon.com (smtp-fw-52002.amazon.com [52.119.213.150]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B7F292; Tue, 13 Jun 2023 12:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1686683044; x=1718219044; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=K5+Giq/eW/XK8GIxl1uK5VSys+gvOj3g0+/asIlylGs=; b=TvQ3cI+mHVKQ9cP5FMZ8kSQwTihgj7kFjSTGVGL+4sES/OzjNKaia0vR 18CcbyX2vW5mxJIYJ6G69rASToeP/X0oTQyym3UneDqwPr37jyoHF+jHb VoykzFx1dsQr3ORSPqV5RbdQ72MWzAJITS64smuE6Ge2bsPg3ZBFxpPNh U=; X-IronPort-AV: E=Sophos;i="6.00,240,1681171200"; d="scan'208";a="566395106" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-m6i4x-3e1fab07.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-52002.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 19:04:01 +0000 Received: from EX19MTAUWB002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-m6i4x-3e1fab07.us-east-1.amazon.com (Postfix) with ESMTPS id 8AD4580D31; Tue, 13 Jun 2023 19:03:54 +0000 (UTC) Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 13 Jun 2023 19:03:53 +0000 Received: from 88665a182662.ant.amazon.com.com (10.95.246.146) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 13 Jun 2023 19:03:47 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH bpf-next v2 4/6] net: remove duplicate sk_lookup helpers Date: Tue, 13 Jun 2023 12:03:39 -0700 Message-ID: <20230613190339.65042-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230613-so-reuseport-v2-4-b7c69a342613@isovalent.com> References: <20230613-so-reuseport-v2-4-b7c69a342613@isovalent.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.95.246.146] X-ClientProxiedBy: EX19D046UWA003.ant.amazon.com (10.13.139.18) To EX19D004ANA001.ant.amazon.com (10.37.240.138) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lorenz Bauer Date: Tue, 13 Jun 2023 11:14:59 +0100 > Now that inet[6]_lookup_reuseport are parameterised on the ehashfn > we can remove two sk_lookup helpers. > > Signed-off-by: Lorenz Bauer > --- > include/net/inet6_hashtables.h | 9 +++++++++ > include/net/inet_hashtables.h | 7 +++++++ > net/ipv4/inet_hashtables.c | 26 +++++++++++++------------- > net/ipv4/udp.c | 32 +++++--------------------------- > net/ipv6/inet6_hashtables.c | 30 +++++++++++++++--------------- > net/ipv6/udp.c | 34 +++++----------------------------- > 6 files changed, 54 insertions(+), 84 deletions(-) > > diff --git a/include/net/inet6_hashtables.h b/include/net/inet6_hashtables.h > index 49d586454287..4d2a1a3c0be7 100644 > --- a/include/net/inet6_hashtables.h > +++ b/include/net/inet6_hashtables.h > @@ -73,6 +73,15 @@ struct sock *inet6_lookup_listener(struct net *net, > const unsigned short hnum, > const int dif, const int sdif); > > +struct sock *inet6_lookup_run_sk_lookup(struct net *net, I understand this comes from SEC("sk_lookup"), but this sounds redundant and run_bpf is clearer for non-BPF folks.